Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't archive paste download when only one paste is present #162

Open
ChrisLovering opened this issue Jun 4, 2023 · 3 comments
Open

Don't archive paste download when only one paste is present #162

ChrisLovering opened this issue Jun 4, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers python

Comments

@ChrisLovering
Copy link
Contributor

The Download button at the top of the view page directs the user to /download-archive/:code, which is useful when there are multiple files within the paste, as it's handy to have them all in a zip.

However, when there is only 1 file in the paste, having it zipped seems unnecessary.

IMO it would be nicer if, if the paste only has one file, the download button at the top directs the user to /download/:code, just like the download button under each paste does.

@ChrisLovering
Copy link
Contributor Author

Alternately to doing this, I think extending the hyper link to include the rest of the text, and adding that it's zipped, might make it more obvious. IE Download all files (zip) and Download this file all hyperlinked.

@hsitirb
Copy link

hsitirb commented Jun 4, 2023

I'd actually suggest both - the download links below each section are "download this file", but the top link is either "download this file" in the case of a single section, or "download all files (zip)" if there are multiple.

  1. It makes the action clear
  2. It avoids the unexpected zipping of a single item

@supakeen supakeen added enhancement New feature or request good first issue Good for newcomers labels Jun 5, 2023
@supakeen
Copy link
Owner

supakeen commented Jun 5, 2023

I like @hsitirb's suggestion for implementation. We still have singular download-this-file-only links in the per-file view on the paste.

@supakeen supakeen changed the title Don't archive paste download whne only one paste is present Don't archive paste download when only one paste is present Jun 5, 2023
@supakeen supakeen added the python label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers python
Projects
None yet
Development

No branches or pull requests

3 participants