Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a share button to paste view #164

Open
supakeen opened this issue Jun 5, 2023 · 4 comments · May be fixed by #166
Open

Add a share button to paste view #164

supakeen opened this issue Jun 5, 2023 · 4 comments · May be fixed by #166
Assignees
@Robin5605
Labels
enhancement New feature or request good first issue Good for newcomers javascript Involves javascript only.

Comments

@supakeen
Copy link
Owner

supakeen commented Jun 5, 2023

It'd be useful to have a well visible share button on the paste views. This could copy the URL to clipboard or use navigator.share() (or both?).
@supakeen supakeen added enhancement New feature or request good first issue Good for newcomers javascript Involves javascript only. labels Jun 5, 2023
@Robin5605
Copy link

Can I work on this?

@supakeen
Copy link
Owner Author

supakeen commented Jun 6, 2023

@Robin5605 Sure, I'll assign it to you :)

@supakeen
Copy link
Owner Author

supakeen commented Jun 6, 2023

Also from external discussion on the Python Discord let's not use navigator.share. Copying the URL to clipboard is fine though.

@Robin5605
Copy link

Cool, thanks!

@Robin5605 Robin5605 linked a pull request Jun 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Robin5605 Robin5605

Labels
enhancement New feature or request good first issue Good for newcomers javascript Involves javascript only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add copy URL button to view paste page Robin5605/pinnwand
2 participants
@supakeen @Robin5605