Add copy URL button to view paste page #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it, perhaps if we grow more buttons something should be done about the UI in a followup. |
supakeen
requested changes
Jun 22, 2023
| @@ -167,6 +167,12 @@ function setupShowPage() { | |||
| }); | |||
| }; | |||
|
|
|||
| let shareButton = document.getElementById("copyurl-btn"); | |||
|
|
|||
There was a problem hiding this comment.
I think this needs a null check or coalesce before continuing into the event listener below.
|
The red CI here is due to some dependency woes, if you rebase on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164
Add a "Copy URL" button to the view paste page that allows users to quickly copy the paste URL into their clipboard for sharing. The site now looks like the below image:
