Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On a small screen the buttons fall out of line #254

Closed
supakeen opened this issue Mar 9, 2024 · 3 comments · Fixed by #265
Closed

On a small screen the buttons fall out of line #254

supakeen opened this issue Mar 9, 2024 · 3 comments · Fixed by #265
Labels
bug Something isn't working css Issue involves CSS only.

Comments

@supakeen
Copy link
Owner

supakeen commented Mar 9, 2024

The new buttons that got added in #250 fall out of line when the screen is small.

Screenshot from 2024-03-09 13-24-17

@supakeen supakeen added bug Something isn't working css Issue involves CSS only. labels Mar 9, 2024
@millefalcon
Copy link
Contributor

@supakeen I'm thinking we can add flex to the container and add margin-left: auto to the remove now button.
If that is Okay, I can work on this.

It will look something like this,
image

@supakeen
Copy link
Owner Author

@millefalcon of course you can work on this; just to be sure: this happens in multiple places (also on the new paste page).

@millefalcon
Copy link
Contributor

millefalcon commented Mar 23, 2024

@supakeen Got it. I'm kinda not sure where exactly we should put the margin-left: auto. I see the "remove" button in the create paste is added using javascript, so should i add the class there, or just put it in the scss ?
Currently, I was planning on adding helper class like ml-auto { margin-left: auto } and just use the class in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working css Issue involves CSS only.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants