Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async db driver #272

Open
shtlrs opened this issue May 19, 2024 · 5 comments
Open

Use async db driver #272

shtlrs opened this issue May 19, 2024 · 5 comments
Labels

Comments

@shtlrs
Copy link
Contributor

shtlrs commented May 19, 2024

It'd be ideal to use an async driver to fetch data from the database, that'll work well with the async coroutines of tornado's handlerS.

@supakeen
Copy link
Owner

It would, and sqlachemy nowadays can do asynchronous stuff as well (it didn't when the models were written in pinnwand).

@shtlrs
Copy link
Contributor Author

shtlrs commented May 22, 2024

The main issue i see with this is click.

Since it does not offer async support, we'd basically need to have to sort of packages for db related stuff, one sync and one async
It is either that or we will need to write some wrapper for click that it will enable it to run in an asynchronous context.

@supakeen
Copy link
Owner

What is the issue you see with click? It's only involved before we actually start an event loop right?

@shtlrs
Copy link
Contributor Author

shtlrs commented Sep 12, 2024

I don't know anymore, it has been too long since I did whatever it is that I had done.

@supakeen
Copy link
Owner

Haha I can give it a try and see if I run into problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants