fix: xfail sklearn's check_regressors_int #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsorber
force-pushed
the
ls-check-estimator
branch
from
e63a305
to
5a607d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the one hand: scikit-learn's
check_regressors_intexpects the output predictions to be the same when fitting on an integer dtype target compared to fitting on an integer-valued float dtype target.On the other hand: this package ensures that the dtype of
predictmatches the dtype of the targetythat the estimator was fitted on. This is useful when for example the target is a datetime or a timedelta dtype.These two requirements are incompatible with each other, and therefore we mark sklearn's
check_regressors_intas expected to fail in this PR.