Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SurveyCreator: Rename maximum... properties #6336

Closed
tsv2013 opened this issue Dec 26, 2024 · 0 comments · Fixed by #6350
Closed

SurveyCreator: Rename maximum... properties #6336

tsv2013 opened this issue Dec 26, 2024 · 0 comments · Fixed by #6350
Assignees
@novikov82
Labels
API change Issues that request changes in the API v2.0

Comments

@tsv2013
Copy link
Member

tsv2013 commented Dec 26, 2024

maximumColumnsCount -> maxColumns
maximumRowsCount -> maxRows
maximumChoicesCount -> maxChoices
minimumChoicesCount -> minChoices
maximumRateValues -> maxRateValues
@tsv2013 tsv2013 added API change Issues that request changes in the API v2.0 labels Dec 26, 2024
@RomanTsukanov RomanTsukanov changed the title SurveyCreator: renamings SurveyCreator: Rename maximum... properties Dec 27, 2024
@novikov82 novikov82 self-assigned this Dec 27, 2024
novikov82 added a commit that referenced this issue Dec 27, 2024
@novikov82
#6336 SurveyCreator: Rename maximum... properties
658a5d8 
Fixes #6336
@novikov82 novikov82 mentioned this issue Dec 27, 2024
Merged
RomanTsukanov added a commit that referenced this issue Jan 7, 2025
@novikov82 @RomanTsukanov
#6336 SurveyCreator: Rename maximum... properties (#6350)
c13d946 
* #6336 SurveyCreator: Rename `maximum...` properties
Fixes #6336

* Fix deprecation messages

---------

Co-authored-by: RomanTsukanov <[email protected]>
novikov82 added a commit that referenced this issue Jan 9, 2025
@novikov82
#6336 SurveyCreator: Rename maximum... properties
d63f652 
Fixes #6336
RomanTsukanov added a commit that referenced this issue Jan 13, 2025
@novikov82 @RomanTsukanov
Issue/6338 SurveyCreator: renamings onGetPageActions onShowingPropert…
12700f5 
…y onGetPropertyReadOnly (#6369)

* #6338 SurveyCreator: renamings
Fixes #6338

* #6336 SurveyCreator: Rename `maximum...` properties
Fixes #6336

* #6338 - fix onGetPropertyReadOnly

* fixed import #6338

* Update deprecation messages

---------

Co-authored-by: RomanTsukanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novikov82 novikov82

Labels
API change Issues that request changes in the API v2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6336 SurveyCreator: Rename maximum... properties surveyjs/survey-creator
2 participants
@tsv2013 @novikov82