From 99a752a89ef608aa35ed9b2990f3568e8b6f95e4 Mon Sep 17 00:00:00 2001 From: Aleksey Novikov Date: Tue, 17 Sep 2024 16:26:40 +0300 Subject: [PATCH 1/4] unify hidden title behavior --- .../src/panel.component.html | 7 ++- .../src/components/question.scss | 60 ++++++++----------- .../src/components/question.ts | 2 +- .../src/components/tabs/designer.scss | 4 -- .../src/adorners/panel.html | 13 +++- .../src/adorners/Question.tsx | 4 +- .../survey-creator-vue/src/adorners/Panel.vue | 6 ++ 7 files changed, 52 insertions(+), 44 deletions(-) diff --git a/packages/survey-creator-angular/src/panel.component.html b/packages/survey-creator-angular/src/panel.component.html index 216e7f8c6..35ea89f35 100644 --- a/packages/survey-creator-angular/src/panel.component.html +++ b/packages/survey-creator-angular/src/panel.component.html @@ -17,7 +17,12 @@ - +
+
+ + {{model.name}} +
+
diff --git a/packages/survey-creator-core/src/components/question.scss b/packages/survey-creator-core/src/components/question.scss index 8d4315077..940bc5347 100644 --- a/packages/survey-creator-core/src/components/question.scss +++ b/packages/survey-creator-core/src/components/question.scss @@ -153,11 +153,6 @@ svc-question { user-select: all; pointer-events: all; } - - .sd-question__header--hidden, - .svc-question__header--hidden { - padding-bottom: calcSize(1); - } } .svc-question__content>div, @@ -604,6 +599,26 @@ svc-question, z-index: 1; } +.svc-element__header--hidden { + display: block; + padding-bottom: calcSize(1); + box-sizing: border-box; + .svc-string-editor, + .svc-fake-title, + sv-ng-string>.svc-string-editor{ + display: inline-flex; + &::before { + content: '(' + } + &::after { + content: ')' + } + } + .svc-element__title--hidden { + display: none; + } +} + .svc-question__adorner { .svc-question__content--collapsed { &>* { @@ -627,32 +642,11 @@ svc-question, display: none; } - &.sd-panel__header--hidden, - &.sd-question__header--hidden, - &.svc-question__header--hidden { + &.svc-element__header--hidden { display: block; } - - .sd-element__title, - .sd-title.sd-element__title { - - &.sd-element__title--hidden, - &.svc-element__title--hidden { - display: block; - - &>.svc-string-editor, - &>sv-ng-string>.svc-string-editor { - display: inline-flex; - - &::before { - content: "("; - } - - &::after { - content: ")"; - } - } - } + .svc-element__title--hidden { + display: block; } } } @@ -1043,9 +1037,7 @@ svc-question, .svc-question__content.svc-question__content--collapsed { .sd-element--complex>.sd-element__header--location-top { - &.sd-panel__header--hidden, - &.sd-question__header--hidden, - &.svc-question__header--hidden { + &.svc-element__header--hidden { padding: 0; } } @@ -1060,9 +1052,7 @@ svc-question, padding-bottom: calc(0.5 * var(--sd-base-vertical-padding)); padding-top: 0; - &.sd-panel__header--hidden, - &.sd-question__header--hidden, - &.svc-question__header--hidden { + &.svc-element__header--hidden { padding-bottom: calcSize(1); } diff --git a/packages/survey-creator-core/src/components/question.ts b/packages/survey-creator-core/src/components/question.ts index 9a6e20022..c0630dc8b 100644 --- a/packages/survey-creator-core/src/components/question.ts +++ b/packages/survey-creator-core/src/components/question.ts @@ -190,7 +190,7 @@ export class QuestionAdornerViewModel extends SurveyElementAdornerBase { return (this.element)?.getPropertyValue("isMessagePanelVisible"); } get cssCollapsedHiddenHeader(): string { - return (this.element as PanelModel | Question).cssHeader + " svc-question__header--hidden"; + return (this.element as PanelModel | Question).cssHeader + " svc-element__header--hidden"; } get cssCollapsedHiddenTitle(): string { return this.element.cssTitle + " svc-element__title--hidden"; diff --git a/packages/survey-creator-core/src/components/tabs/designer.scss b/packages/survey-creator-core/src/components/tabs/designer.scss index 69a8ac350..2cac50d33 100644 --- a/packages/survey-creator-core/src/components/tabs/designer.scss +++ b/packages/survey-creator-core/src/components/tabs/designer.scss @@ -42,10 +42,6 @@ svc-tab-designer { .sd-title { display: flex; - &.sd-element__title--hidden, - &.svc-element__title--hidden { - display: none; - } } .sd-container-modern { diff --git a/packages/survey-creator-knockout/src/adorners/panel.html b/packages/survey-creator-knockout/src/adorners/panel.html index e08a82620..2e5af6030 100644 --- a/packages/survey-creator-knockout/src/adorners/panel.html +++ b/packages/survey-creator-knockout/src/adorners/panel.html @@ -19,7 +19,18 @@ - + +
+
+ + + + + + +
+
+
diff --git a/packages/survey-creator-react/src/adorners/Question.tsx b/packages/survey-creator-react/src/adorners/Question.tsx index 071f72778..133747688 100644 --- a/packages/survey-creator-react/src/adorners/Question.tsx +++ b/packages/survey-creator-react/src/adorners/Question.tsx @@ -104,12 +104,12 @@ export class QuestionAdornerComponent extends CreatorModelElement< } protected renderQuestionTitle(): JSX.Element { - if (this.model.element.hasTitle || this.model.element.isPanel) return null; + if (this.model.element.hasTitle) return null; const element = this.model.element as Question | PanelModel; return (
- {SurveyElementBase.renderLocString(element.locTitle, null, "q_title")} + {element.title ? SurveyElementBase.renderLocString(element.locTitle, null, "q_title") : {element.name}}
); diff --git a/packages/survey-creator-vue/src/adorners/Panel.vue b/packages/survey-creator-vue/src/adorners/Panel.vue index 6f40731ac..0367108b8 100644 --- a/packages/survey-creator-vue/src/adorners/Panel.vue +++ b/packages/survey-creator-vue/src/adorners/Panel.vue @@ -51,6 +51,12 @@ >
+
+
+ + {{adorner.element.name}} +
+
Date: Tue, 17 Sep 2024 19:00:42 +0300 Subject: [PATCH 2/4] fix angular panel markup --- packages/survey-creator-angular/src/panel.component.html | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/survey-creator-angular/src/panel.component.html b/packages/survey-creator-angular/src/panel.component.html index 35ea89f35..f8300e2b8 100644 --- a/packages/survey-creator-angular/src/panel.component.html +++ b/packages/survey-creator-angular/src/panel.component.html @@ -22,7 +22,6 @@ {{model.name}}
-
From 5161ac3e3123e095330a31815e80c1da9779b2c4 Mon Sep 17 00:00:00 2001 From: Aleksey Novikov Date: Wed, 18 Sep 2024 11:57:54 +0300 Subject: [PATCH 3/4] fixed hidden title markup --- .../src/panel.component.html | 9 +++++---- .../src/question.component.html | 2 +- .../src/components/question.ts | 3 +++ .../src/adorners/panel.html | 6 +++--- .../src/adorners/question.html | 2 +- packages/survey-creator-react/index.html | 4 ++-- .../src/adorners/Question.tsx | 2 +- .../survey-creator-vue/src/adorners/Panel.vue | 2 +- .../src/adorners/QuestionBase.vue | 2 +- .../etalons/composite-question-no-scroll.png | Bin 10950 -> 10927 bytes 10 files changed, 18 insertions(+), 14 deletions(-) diff --git a/packages/survey-creator-angular/src/panel.component.html b/packages/survey-creator-angular/src/panel.component.html index f8300e2b8..7d9f6c8ce 100644 --- a/packages/survey-creator-angular/src/panel.component.html +++ b/packages/survey-creator-angular/src/panel.component.html @@ -17,10 +17,11 @@
-
-
- - {{model.name}} +
+
+ + {{model.name}} +
diff --git a/packages/survey-creator-angular/src/question.component.html b/packages/survey-creator-angular/src/question.component.html index c6f875e5b..b55a8d28b 100644 --- a/packages/survey-creator-angular/src/question.component.html +++ b/packages/survey-creator-angular/src/question.component.html @@ -16,7 +16,7 @@
-
+
diff --git a/packages/survey-creator-core/src/components/question.ts b/packages/survey-creator-core/src/components/question.ts index c0630dc8b..c7968c3e0 100644 --- a/packages/survey-creator-core/src/components/question.ts +++ b/packages/survey-creator-core/src/components/question.ts @@ -294,6 +294,9 @@ export class QuestionAdornerViewModel extends SurveyElementAdornerBase { return false; } + public get showHiddenTitle() { + return !this.element.hasTitle && this.element.isInteractiveDesignElement; + } public get placeholderText(): string { if (this.surveyElement instanceof QuestionHtmlModel) { return getLocString("ed.htmlPlaceHolder"); diff --git a/packages/survey-creator-knockout/src/adorners/panel.html b/packages/survey-creator-knockout/src/adorners/panel.html index 2e5af6030..33decafb1 100644 --- a/packages/survey-creator-knockout/src/adorners/panel.html +++ b/packages/survey-creator-knockout/src/adorners/panel.html @@ -17,9 +17,7 @@
- - - +
@@ -31,6 +29,8 @@
+ +
diff --git a/packages/survey-creator-knockout/src/adorners/question.html b/packages/survey-creator-knockout/src/adorners/question.html index 6e87b687b..190cc32e6 100644 --- a/packages/survey-creator-knockout/src/adorners/question.html +++ b/packages/survey-creator-knockout/src/adorners/question.html @@ -16,7 +16,7 @@
- +
diff --git a/packages/survey-creator-react/index.html b/packages/survey-creator-react/index.html index 05aabded4..f744c41db 100644 --- a/packages/survey-creator-react/index.html +++ b/packages/survey-creator-react/index.html @@ -8,8 +8,8 @@ SurveyJS Creator React - - + + diff --git a/packages/survey-creator-react/src/adorners/Question.tsx b/packages/survey-creator-react/src/adorners/Question.tsx index 133747688..ed8518b6e 100644 --- a/packages/survey-creator-react/src/adorners/Question.tsx +++ b/packages/survey-creator-react/src/adorners/Question.tsx @@ -104,7 +104,7 @@ export class QuestionAdornerComponent extends CreatorModelElement< } protected renderQuestionTitle(): JSX.Element { - if (this.model.element.hasTitle) return null; + if (!this.model.showHiddenTitle) return null; const element = this.model.element as Question | PanelModel; return (
diff --git a/packages/survey-creator-vue/src/adorners/Panel.vue b/packages/survey-creator-vue/src/adorners/Panel.vue index 0367108b8..2289cae00 100644 --- a/packages/survey-creator-vue/src/adorners/Panel.vue +++ b/packages/survey-creator-vue/src/adorners/Panel.vue @@ -51,7 +51,7 @@ >
-
+
{{adorner.element.name}} diff --git a/packages/survey-creator-vue/src/adorners/QuestionBase.vue b/packages/survey-creator-vue/src/adorners/QuestionBase.vue index a0272e652..7827b354f 100644 --- a/packages/survey-creator-vue/src/adorners/QuestionBase.vue +++ b/packages/survey-creator-vue/src/adorners/QuestionBase.vue @@ -53,7 +53,7 @@ >
-
+
diff --git a/visualRegressionTests/tests/designer/etalons/composite-question-no-scroll.png b/visualRegressionTests/tests/designer/etalons/composite-question-no-scroll.png index 62822a502b7bf1492ad670b82a0b57e884ab4d4c..0b4ce60e4c9a33fdc2c8eff7fdbd718d54aeb7d0 100644 GIT binary patch literal 10927 zcmdUVcQl;ey1$4JJt2tR22oSgFib=pglG|+=)HF#2!d#X(Md#f(V|B0eTWi0dhfl@ zeP{ALzjMyI>zupRU3cBPe*etOJMS(}`8>~l_Gj;qmx?lkcvN^87#M_5SxFTPjGGAH z_v~$K;8QeFtq%CYgi4C5x!>5N^7)B@!C{Vi+G--SPYE{swBiQwZ%xX$6)jMI#D6m? zL|myKYf3WRIvtmdJHgnt0#>pWxlU`@p`@MsP`t@?Rnxm z_*zjw8_-$+5Bc{yt@H+c9X|f*C*`Ey!Ns`1|4^8-4L7kh)9ulzU{pJ3O@%?*1C=E4}Eb9Jy~WJCc2r5>J3z9P;M?c2>O%O?flTf)YSBKsl$TwXpuewHk7Tz z%gfsW3#S$=^||tdr-;2xN=&4LTTfL*A8q_%hQhW}Fo4NB>UNv)dl3j;2n3O+-CByb{F&D-~edhv_8xZOqEK;0Q9YT&DCDs`sVRB7VQ|}75G&8WeMAj4;t%M%AYeV#7(__zo=-?EP;A(OJ!9DtL})!$ zd;>7;_20BFN6-3SXjQg&xHi<=+gohB&>mi(-#`Z_xPm1M%M{uEw`%ct%>_~b8wxJ_lfNdC~VP@ww*{vuhxVf^1cqK86zs1nc& zrKz^fSg{|V>Fz6P0c!(5Q$V~EnRjTXT5>!?JCz@0W8j}8y#K=YfRI45VYUC^?w_=+ zvU*>-`Cm6XELZoLb{o^nMakaF0h9s!rHko26tVMLI^*R6$DWXbZ3C~W7c~0`O_~%+ z7U$$!Q?|dajnX{V*?o38X-?n^G$PLamADtt25z@~B_FobwTEga? zL!3KV`0+ySof${3sU$_o_tUHl%+!5UqFY+j!6CNweXpxzJU-ebb%5Zl_DyMSY5@!4 zJA-9Q?V@yJ+$Roo;A-$f-ah+NC2y9|?ZkoYrJJ&lNH>fv26$ajta{k;;2u#0{!xc-Zgg$KbobF%iE=xOtO`E&yP7xeM}5_ypJe9I4!%lza3tdS-HT)Cf1N#64J3oPhjue>%X0FQXJ$Td>Me7dCfx5ipqcbIU&Fkz;quCC2vg%g zjI}Nt61zFIg=l7&HMGsl2=$x`CtO|H6461r#wu>3fcP_&!oJd~S4HH;q1_jeeli>F zb6H2;e*03_dt(F-e!^<`yf+CfWgKZ$=i}lI6&W4ow4P!ZKiA!gpC4p=7|KpTb;+U=J232wH?U{YwD6h zfKRycI3Wam4cYRa?uZ?eA_QuQX#&U82xVJNSTW-TX_qmC&dG z(duGplsgSta^1|pA9^W5VWtRsZ1aWld50NWpEPWZunx_``-tm4JzNLYM!BNm2kKV#?xbbvuFp>H?}bj9 z9j;A=2}}jLxl^!4FFiy$P7oirvUt@*PppOPpd8BTUKYju_H83pOu5I5X38TfW9yxT zMqJA>!f*Re`pRAI9^D{~8Sb}l^R|I8H^Q%Nh5rO;pO!nMH+A{KJAKIMnaIwkWIx@T z_vl0$BOcZ(97l_7LmXmTNM+1%mfa;ZPME(tMNN-$m95z}w>z-1rDYr8_wEJt`{^#q zvF{W6rj2)`85B3%G*x=!QlPLh0BTVVa1`h%v43atmUhawqG|9d_?_5!#d|J%!J!|w z@)nqlMS|8AxKeKhNY<*e-DG|$CvyN6z8#tU1DCoZ5$v2mx^)vQIuMRB$J+L2v&{+A z$6|%8x|_{6BsG08DDX;2nWusm$SUT`w{>s+7&}p*H%dpmTq3lYJhoqDAG?SP_!vp| zIp6LbTiR2}l{uv-&oseS=F;H$_T`^KfdL{OhZqAhZKF1mYdZ$YoT<}{IPzXkg~V{a z4~_gnsOr-i7RSifcx3K^%4v;gW>V*5e=*+!5D#~EgG=ad7yt=_hDx+o$BW|am68f2 zC6lEDI$_3#adW+4v5ci$?|Rv%o@2(0b|{c$(cgbx=l_=L@j2BKvecA-6xE%N`{ zmEylQdtM;fCuO<}Hr1sqN40g$jKn7rxdh>JMJoNSq$@-gXj6Pml}SrPr6i49GTF@i zMGlwJyPVDP4F^uO#~Tfe!Fq2~aH2rdw3hcs*!R1bhQ9JK?lfpIigOTytAdLZiH7=; z`5zD;MSbpcW`EI%_Y%qR`=aDw%MfC}8NrzY8M^Yh8R*(_sJD`qRJ-xQM?7h5yWZg>WVH;brkMY&H zGZcP$|3(g#G>1g?3O3)N%yOj8pme=~SPb z(>8SjVyfYiE+5&W&v4z?@rjV9nl`gLcEq@2+`ydD&Ezd~GNUGFt8T@t`R+*WgX z0}ptIV?HP41M4SOE*VLtrBv353vanw?4{oqXYkRB?ts)@2&C(J4-qMKE20D!ZtO{7{5lrZU*}ijBWAPwO&Z!S;FnCaj=Bfo>_m}UD+7ZZh(1hO z;?lS7550nzC#rH@$wuXooh_#c9PiMX%&$V1h0oo&Dubh)J43F1bdj?PJ^j@bFiCH= z*~M71P&?P_K(sa8bGoRk*zdACdn_|{Bnh`k)fw6-U=%vA(L+w#9h@UwNT{sbw-ngq z-=ynxV8Swg{HBbEm*0fACop#?K9Ld8eR~sJV)p)US%@O_^Q(!Tv1@2VT1vn%PlfGd z{{m1CkVF2{vQJc9vBDITw)N?F_r@_Cdps%pgOjM4kRDG7a@H_{Mx={o%lU|Kw>9nV z&*TLzD-<@1tM_TKBO*(!E*~NKDu(!@zV0qQ(xx&2mVl@B&hX=JV%W#vt{I!u+VS3K zOnpj`&bbv+i=Fi^$i2JL*gq^5Cf*PiEHtNIKR)oi6g_3#O}*Q1r*qRrw;;lo{`3*x zG>bXCSNWxGD-VLLXsxGf;;h|gj`|0J-KN}(Pv|70FqfVPa7;@wx*txrv62qp1#y+Eh~INz&xj^NXJv`#V56J zZRcoS9K)G+F+TXNuTH|avhPtj5(DRnh>%BBTukBJmT^(OhUt+=l$5lKRa^s3uMto>@e}+?&lW$*(v=iF{gCxn~)2e(=~m= zt0G&*2#|$|`BHBPwBObvrG!n`+=j*kxhjx*QY*u$ZNOO}-41t>yZDGpO$6e#x zk-W!}IECR~HtA{EVj@U=tlrNEY0ywo8fS37ad#)K>tK88>>fLu$b6UzmKS=|n`XmH z!%j2XNZ~eg)h9vVT56qD8=z(y+7}tV+bfG>rnG71yn?W=-Ba%#x1FyY`EAq^<1u@Y z(l6FKUZK>iUue`<|5&W_E)@3dXEUDT=77&U|I9#~vAZ_gFMh$MyP@6(+7`mqnUC8J zoCf&8y)S(Qdps{F7c+`~#BcMEPb1(t@iS4>Bs+AbizQcJZ-a*m0os%y^E#?43|}Pz zbVjMC5eLEa%ZEV4owmT&n_@v;3tVekLOmgf9aHOhhx6bc)mdkxDgE2Q`e!Qz$mU9qJtt&r zyfE?p;KNH%V52&HHGdeP@UzFH&N;PkZ!L9USn=Zkb(7A*gGY@6_DMF3VV>jgWmw;# zwDuSxhb?Y;>Z%gQSGmA`%Jd^Rug1PH&Zz$3 z!aSL^(tmeS9I!+XqOzWq=TT&R?>MqNY~;5Oi~)I&LQA#sb$tPRM+TP3iTNt(3yusW zEv<>ObL`-tvUDV3aEiP%GJ9?DMRVVw*lo6hfXp(M2(WLEHnXCg>qoz1(vOiei$a1A z=-3vuDt^)j>X1hUb8T#x^2P^#cf)Y9hqIUoX^P-k2gO?{ym;}LpTAA*rtmw`a!o3o z$#LGI#&$&UIXx1zr*wr`h|COQxR&T=hHB-`7oHrL>P|-v^kYS41wDwh;#;of7sk2Y zC3<^AxjiyvPP$EdXC}gQ2UcgQOl+XWO?2ld~cb?;HG1?9G?S3vA zRG#QD_Yu?w*CrnqMwYB}p>kL)n<1n+T8z~-;>jyTmGwoNWwQu-_uAIhJyIGkTlmJ0 z^id(Zn9bGM^M1#yrVOKxkn=|iwQZN+UqeZ!T!w39I){b=;IoHOphD1Jc~aRDLBFs_ zV>eV`^N|_hT6V%|w8+c8?;JH%7TIhsNxdVLvORZ~ZW8$j=Qx75$|a#vq-D=BsL(iWjm|5CAB#xBOxBd85N%VybH6Lr4w~rZ6 zG! zNZ;-kn3$Lly4dIXHB{k2JBy)cHhjY^F_T@>Ni!i{qF1KiStgqZ=m1gC}@W8pu%|aEqw?XvpCh6f7UpE7r+9 z^t3okhh6G=4#9gdMoMt(*0_nA6%n^alVmLP9QIwM@6~vNZ$y;fn%tAx!mz$czZM+! z&ELJd@K;pjB*BptgZo#f__ml2VaQq}|wvI`BD!5nv!{$;HgIMAnFiRVKWm_MU#K3#-4*K3(r*NYxo0MPebq zqXs8_4nUFNzT1^exjcP)4G}&dSQ7K47J988ZBI~8x!&3ID->1?Q#Mx0DRVkaC1FJ z?MOhn8vnz5(tmH4@L!Q(TCZ>Dc`T9Xd9JbO`Chq@laoh*ELg(Y-W2H7CE?JyzjN6b zbzuI_O}>WyQ~sTUx8p0>hC!by?W=pQ-=c7ER zsptRcQv`e!XqAVm=fB!h{HHgl(f)da?&i<%43_Doeg~^I2BqAZ-aV`voKpW^z~Nu* zm;aZAcdLHQ6$FBw3v!f0YV74>4 z(9?s5E%Iy@mRD@EykCmhLu^0O*Ax66!$+Q^Kkv~xJ$=|{=1V(m3OS{_{B(o<>Ym1# zIIW&lqm1VOt^F!}W8#iuTTlbB{;A;VvAH-fr{K=-OO9HB4iV2ikw-^X=n;#Mtd~a( z^Pvs*gGWx90vbYXV~UX2mrF=Y`ZYg&;b!&vBhclM_-Tp$d*mhi>$mhZ;r-qeuDuRz z^{&nr-+^S9nS3%q)8pDZI9%`Qz68n8-c*Y-3D6J5FKVH`zUO^VIh))dr7E&K@Iv^6 zs^{94O7B$lbTHj)JPdi``kbLhFF9c3Q5zKC5}QEL9C)d~mDxNxvp?$1`gJL3;2 zzLBdeoB2tFjas}gia{#SQvk^CYqrA=hzDbG_f4ziQmtFLUw(;_75}OzfJwz~DJjW# z5)^m~&aLwff5l@5O|9s_Glg`SX!mFMEr&mRc>byau{iq!DbkxBWVbjc^ANbKh% zt|z*3q)Y$=#f15BeXmX2*FYNMzxvfjeKEy&@seRvQGb+@D#r{_^Vf1nQW0K!l}9TV zoky0)^A)!m$ND^Ym)?h-$Zjb#*j3_tm|Ky!#{(%bP2-waRxHbSWc2@#47cTJfw=_QczO%acUX-%WU0mUl>&9a=y8k_9{&(#d5a_$9KVEO_xj#$Ky$(e)xP7?O#n2mXZq!=7hq!<)r*O_ zIAmuZo)?ZR%+QtmwiQ76AUk7X51;4H{(p9ee|;w92s6K5?-jiO*$<0`r#PPb5Ss^K@dl6jkLADzcfK zWjRRJXDx4QFS~i|Ucq zdBq8mU8)Ajd`)9{14Zk}@|1&2mP|MS04X(qY1aD*Jkdm&YC!BOa{`hF^L0xcDiAyZ zB2b{4;HVdty8USYpbXJ5iTcMl$5FXd=mk4%X~8Q7w2?DA>sU5v8K6PqnheIu=wmq! z3YIX1_@D1cNK^JN zNVR)Kv+=8c)+>_uf;x`VUDA_VyOSZFm0k9pF$|TD@ah1h^yDStVrOj(|8bh=%am`b z57A^Vdn_f_S6nLqQ&eqh!fSVO0O}a;aI{R4Z*RaBKGI&5WljP9P7NfP8+Tku_IMUm z71Y;drdufBN)dKT zh#F_$9jRdP0W@=Q{**jBt>fgD)k+Y74=qnEk?*PM?li=&(Bm6R_h>F)54k8D6y$HC zO>jqjJ(dX#28yK_l5x*le<504gCW{qPE@{Cs;pK$ZCEYPvyKQ2G1oXR_OE8_e-Ys? zfjlGrH8yDfPNHQ5syXdpI1;xXaS(C6Na2w@#&Q3e?iWmnrPE3I8<74>3eaq9;BFc1{5_G369&2fU>KLGt^}<9ZL}Fj5jJnoT3Q_M2U4(yZru^h1>3GHRUCRmt+SN03cL!{N zgo`6-6hw8$ApjfS(c{XlJJdq7D@JB|Dr$4mY{fKPAaUtq=}!-EoY8-NOM!t|I^$ z`Y$)n+<+O&vh0JxhGKs*y0r$mp2<7w&L9X+(soT!#`jq{#z9C6)6g$1v;DmoTYD~%$u>W?O0Uf|Kp zbdy1n=A|Xa@v6N6!}4^Y)_|&MrqVbXU}XkV0NI?0JkUb!hz}?(RvDwAsN;2_>N=k} zrB6!|#phz?XLr6A1U85eA%*+MO4J|i`abi%S$pjE2oh2S^GTx_7qxgI$4hwO2WB zw~C8WO*VYqQxBr678n;1$zITc2|7W4XB21)SqRm-DHcX^_Epob9Zq1d-gmL zTi%kUTdi6vE+iMb$5M6CgCaxEaS=*psWWIkV4y661Kq#ZO$Z+$iq3UJm;c6(3ctl{wF;w$`7CJXX5drJYaufWq2zT zI}CI{sS*N?%6!cZE9l=(dvDPmN_v<{vZx81K6N$S6J%6S&Fh899z}K9E0+RwT;C7i zUIP&EqDb!@bCpz$apgPbYdHh-dhRBp%^fQi@dkl4f3xb?p%0}gsqACO; z3m%{fD;SIcLOKIg>uEE_%MQkLVn9RVn7T0IB@dSw(%1gNZoi^x!BLdlVl}EKVYO5J znf7jcLl2qnW1@WE6srL<{er}MTYf6aJ5(}_6Nvk@D5<;SYfR;7_d>w&i#fw(@BeAM z2$WBUVi;mjA$efy>Aw%iW5NTe-fx}#*<`*kr;*+sjhjT+Lo3A55A44%l@3W+in5b$s{F{7$E%?hK4$wHudG<)+7b$5ptc%@^qyJ0`)a@vxfkxT0| zRSvAeK#f->siOugA*jm9{deja&*hv_OCbI84gp!(pg{cHUbEQ?-)2x)^yEa-!oYPk=+C-0bC^0p2)WUO zT=CKXA|4>61{llWxCJsJv3M@;d}sm?Rr(quy|2Xjn(y+A&KYMj!3e1K;adq3l}h-) z5H$`~5Nu#G3GBdV3oq_ECvO1_Dt)Le_5E73tLHyY-`RTe6?e$!9-HSX)VPWX*c=gg z{I0vk`+oI+&vLg*#^5T_sjXvZcPHJSB0U&hzAB)3!o1s!ym>KUvED+vIvVI z+Pyz-C;IE0LuW7Zoi2C1e47H#;$K(U6QM3oz{FO8GxLS!OL_F0GmVu~PQbS3Hz)*r9-5`=f3MkSDl9JMmpn!tZ3?SX5(nt&?0!k0v-QAsY z&y2p`_kQpFefR!%fA94VnRCwG`|Q2ev!1o~v(Lw;Y6|!`R5&+o+`xw@%4*)Yf!PE6 zUd6r*{NL9x+zb4{fXGTe^SHT5<=21X#sh!U)z(jZ$K()`^c8Y?X;amKKt<}A^TeBN zE$OV581|X!m9LuGNe|8KOI1kIz!qctQXVtj%j7XyGY94dlg{LIXb|sU+HlQke zsGAV^uw~w`6o@KflCt2H_YnAg$~UNVJ{I0y>>UNuOyAX&nvxVQ`1;#(!G)ohcfS@2OwG`1`<~>qK zaa>$nPEJn8^+9$n@9VP_T^*g5KntxrH3kTD8#NJ^){5`n9UlV!43w3XaiQR~E0X)b zvuf2O!DvOWPOaO+Btg6Rvj6Jx2^2h~TZo#1eRD9r?Py6r)p&^sCbgjLY@wj-Xk#!w zHL%2;$iM6Ub`SO1`u}$ssm$DUyBOu=<(y;HZpeL$_7^0jFedquyFmCmtaVL%1|h33V)a7@eQ9^u*9VK_VnvN zE58YW9$sVrb?ATN@Bf*{Q+nn1g1w=5q><%~c7pm0CoiF9Ws0;Y2=;Fgrzg4jAO)en zL|;I_ijEg4sng0VDNDOFC}d_&aL&429H;Fs!qoTgC@jOPXjVouNa|FD8ygnzbDbo> z)wEVyshV?uNpO=qg>8h7Y4@ z4Y#UEwh|NhP1Og@^=3BgN_^(L44((tSq4ZonJqdfpKyuzCd+uA@bb9Ezz$NxORh}Z zBvN1LlaoIbZymh88+r$Huu0QaDx`}ytHqRB#-a0M5dZGWF=h(5CMHiDx4v(4oB{>?&l5VzHxh{#g9A>!3QZ< z;+Lmv-oajqC17cNYFpp3CK8z~6?`U?v1+>Y;D*bQyAGDy3oGu|cr$+c+#U%@Bgx|s z7O}hfRR^PrAd>@OZ~8AKk9xXw^R;M{wBprEEiWl6zjyNplz!&UQ{Nqo_QiXTtK!ex z%tVr6>p#yfU%Rug1ZQVq?RhNbSOW`~lUAcinH@c5^|0_3>P0MHy#4H%6yz11;SvBZ zoS+=%QyCRU3}#Ga=SA$H2dkTFW0Qg16$BB$CWaS1%md$vMal?wpH{lXxtNEN>h{Z` zopMp(RO@29@MF3?)8W8wI&48DLY;SJkF7_%{&T~v&Pw&A)5TItIAu9(fi!h%w$$>N zr~mUyi17-gnvaRl0xXi}5plndJzb3g1tnd22(vF9-W!bzi}TEfo0b~xAYWgi7j<3w zUA!Vjv$~ZBgIaR8$90c)9}BIy1njl9Qc$eTg_1bS_V|R=``(Q^a_2n>nxYZ+gYMZ8 zp^+xWJ!?OboaKi>F)FVf$T41Z2%EP^UN*a8E1@(h;**f*K0M?fP+h&HHn?I%Tn68{ zDXjaF4VLAzD5B;JOJo)HBK7cyD%>)N{%}rlOHGB=GERuv?7ott+=cICYvwtpDw=wC zLbSKNa5+oz%TwH@!9P_+o7Y&vB6#-NWK?#^0H$1{6loa|?cAj0D7oki8JjANRX7p< zX=TB8cRC!4OlNRRO>D%mpk2K8mpQ}7Tj-hBDss5j-?~fIowCf|i#TE?uA6GYP%Vm6 zELqh^J*%xhWUh{I69g@?fj;#XsPjtJz%a*XUF;;A6hT5og(*>Ttcm;qQ9^ZHnS~6r zil`yCEpG0FoH1Sgg!wl{drs?)LcU|gi#F|H73m23eWG$8Bepl`>#Xxh@)|KBf;cq#eZhcEKxRPkFWIkWvPI80^(;8HF{`JH+l&LW;fUXA3O;g=^ zo>E;u8bPNwxw|lF>)z4bcE{KBS-c_EaLEe~xq$DqXb`B=Wnjjy;7>__27XGrtvGd= zdtoQFCM5bqARa#Ip{}{@9?hM{E`Er$Oy`@N5ug??_Vch5$FN!JldS3kI8AGlbmft| z(@X-3!U;Xb`PvL|8Rw+R3|YSFC+G%EMjD?BJ^|65wjo}`GCTdl-8Mq;xHSe_I?MH5 z6EzpS{lS-@KL*z4sG7<CC{@Cw~Uz zaG~!G6U`Z{COa<(czN93Z(mE(`JWRShDbrqMW&-Zw9%eZC3TXJg0>fwAy@hKs$8^5|?&$iO>JTr-nsKO^n)^7D02ODPtbWv~Ucr(6YgvlW zL+!$X`&XbHlL?FI>?8s*W@2!4keYh*#UjJGWrx`l`$q9QCvlYHiA+i*nT6Zu>_!)3 zT!7{2Wm``i7Q%2B_??J^7RPvgbG(b;W8l!+U%17oR3rnZgxe4?BDJ*Wuc=pJ*pWH|VNl+Z?!|4^L2j+7BgMkW>SpZMR(;-lSsa2a8yK4 z&Adc~WwC}Vae#(yrY9pyATX&Ko6+$n+3(I8_3>as?!9h_t<4#U--~^)F8AXD zD?dPpSIPSXPUvzbQ34eBYnx=p{hCy`|) z$XdP1f3$D(`$YZC;i9;UOS$WW8=bd!Yh??OymPIHBZhD^i|$K}(0-K!m9`2AYMx6K z)}s)Dk}C0*VFTH~4Uz6WrG%?HAm_zV$nsixt$$SO$tUPo@=M+FCP#<3?xCGW9zLH8 zNkTl`ir#Jir1`}vKiXeV;$F}gkmc;+a>7@=a`)JNW4_xWlJudJ>5QB zs6R%`^3o)+*o@93(^*ViTtMl>mzz&WpnZ|j>JCB{#8+kqoeHViAJvK+@TVtqBXQt+ zm*v@^fcq(&-elrba2#IQ(nO=M{Dk)`j}pJfao;g|>Xmiki7!k>#?U}xq9=mIcAJ`| z$}Vp0>W*;K)X(;2yJXuiiuSDx&$_0TxhcG$DIc5fk+;Ig)=5M9Ntd-YDgA>V+BvJJ zZZ37Mk%+sR(PJ_=9AxzPeFV{76I&veK?%r9s#ArT;Ixb9!^m+mVnwKSu%KF6{Crnj zD}{d@ta4f7I8rsL8;t!!K*<=x0a(GYlNDk z?FET=c|En2<$-U@>zz&>N#S;;APoZhB-8AW4XcI2kL(Cr&rf@;V%9cv=E%`oV=95W z`dL5@o^M+vgl!QqF?p|wN&d=cewD3GpMhMYZ2C!bY@4*CxOd}DLtRp;1D$Dpn0a|D zZFc#9t)ELwo`RT&v#Hc8u^(-F%P+nxdMWN|Bj4hylfI?jeX`Af`0kH$Z9!{u9DdLj zt_XFB)z*%B6><#AKM39?WdeX(bOwodI-fMt(ffPy(uuvl*d60zf zp-cIyWTmX{VbElhY!7x;2EQXNT#;?#9r!h{fFt*=Z5aEG~`O%plej5?;3q?D0prAbGm~|s3g}$ z)`dz+&t`JEpJ_}3_HvR!fON0|uPv_bU~47bXWLxv@g_eq*OT56@;9%Z+}_VRRNpqU zt$Xq{IU~#l(kmn?NB{Y#&o>ug>8AEnibu(~JQ8%&)Q5PQmuFg?=>~?-)Ut@*zt$1Pczi$43hU9Ps%qKusPd$Bm>D{;G6&c zMDm$&jqcSJD>lxL#)P@MMqed8%9~S$ z+=19W7gak_Fv2*T7vTewRCmvv7VzAXUz#4?Z-q;Lyu~n578}5}SSHJ8rt1$%f^%kP zk;I4aaf)=epKHA2t240l@=9D=v(8QGy_=lh)3-Q|NcO`L^otup9_B%O&dIGWET?XL zq<=#I=~s%is*M!d*!GMkVDSV?sFZ5v!5a(v1lp{wZ{~;dyjkQIdeG-aKk{9`R5?(Y z`1@3ACaJzRvB5B%Te+D@K$u$UY@0Y?s)_xdH|A|5ThHLAyzz!xSGwh_|S_&iGbGb9beW3J6<5-+W$-+7C z1Wa>ZYP@F=0pu?B4#T?crcELO^_T>4zra^Lh&R3`eQ~pPnkgv;Gn8sVx-OqSD$tn* zRsmaXuW@J^6Q_Sfm}FBh>$N2q!qILW@uFi>$|L67xm8%CXX3j9^-3F`#O76paFA^x zMoRYaW|lBpq>QJj&^SAFL7rLriuM-_blR8iJC2Bta(zj(}lsR zuu;YDRs` z-qTGd75&uMU&7vrt}+Qpwk#nqp{TKdEZiwkKGV;;;l#D9j4{CKT2f3W$NjE6Z;v? zKKD4a&(FiHpbPBa7I@ww{-~*F@`i-r*7vF^=jA04`-JTe83e+Do}YjUq2@^MEZthW zZ7G6?z&`88fh2-IvJ6SsJJS;vWj>Wug&9IQQBPj!&NtH#8*OJenJ;S`vG)@~mrzie zofg*A?Q5GMfAun2W((6LRiu4xpVS%T*y)15&1kHq<*|y}C2=k+gPHQkJ#g*Sy_(=W zijPs?!e`C`$2)1Pi>ftRpKLcQ4%}vUr9&@-_{ws^E$X}GvbJ1ygS|>4ueymeCu;6a z7%eZ(T@9|zmgXm!&sm&TKDINBF<8OAO3tux{E(kQJ@{+ZDs{gPqk<}G9%?V>aEE|C zyV{?RNq^jGxRXY5T37!*MEzD(^0v>W_tluvY)*8VxG$~&y{P+VHB2*j; zO04AaYI+xQLT6@5x4N3^KMQFP6_q6?uKv?i%OewfTCE`^Ir@6D>wiQM>8irf~B1{a#K zvLsL>Ej~E=09X}o^Gn%^O2qsqllWj?_sgQThCFhLnNz~guC~)1O@p__Fr7Kqd|ry3 z<())tC_8F^K;&uZ4X=`$Ys+cY{Nm>u33uc(E#LPkoE-E9cuw~s8dD#5BNo{rB${Ms zr|_0TH@&?A_QFALzPXqmzX4BnoVNIdjx~2-rhu|n>9-dp!4NM8JuXi4wgqhX0#Mt4 ztx4!TKrI7)nPQ>$r`bAyZU)?7*ZwznJk)`++rd%1+po;McfL{VJlBK;RJ-kZdU`tb zUIHgG{!$ymg$wd^`yCv0hyBWR*XJ7s)sBElr~Nf9j!e7QsQc<dx1{ z73fz*2>+)h+BMEAh*Gbk*G9fa&w;A1RjIebkP91QxIkCN#)bn>Y5|((wz9T1X-B<} zRhqEGqMJ%jU*Fo=S{j&dQBF<}vt>`Jc@B1UXQ5t2=<{#def|A`V8}@*YR!duzrH^I z=E3?+yU=v#>vOai+Fzdz^a2`|z8-p@9s0J`fDn+BU5ar6-?|gu0{lG{7I^<<&cBtg ziN@rA64C!1cEy1C&{F!;HvoqotbaZB8t@p(C4l@4)b{mX0fV~(ax}^>nJB-YtPUUw zz{f&U5Gs`yS3AyO0GC;Xh2ie~!^6Mf&MT-}fH!ct45}M}ODh|jS2@(== z@n%MGktb;~8+xZL+)XQfm{S%~mvomUcj+(qU!0j>8rd`{c=ypdu3F9>y2DMIrQUO2 ziMe=xX9R4Jbh6`zZ-? zk59i9WGvbAyy589<(Bm6N8>=`CPe4T#DzNLnrkzDCDfO8_1GG9m?X4Q;Tg9T&pO;d z;ISl?slWLw++4;u4U z*~qfVQAppz%HnrbVmK$fM^}qvC;=s7{66{3Zc$gp%qZ{XAY9H`M><5>Lj5Kd2xVjS6c?@Dfd2qoluz)dj?9rlh7C6TC>^Qt&h{!Uu@h7U+5>1sR)!LQ#LwA_*B;COuXG)@maWgrvxU#t$2 zUM@K_E3?8o8VHKYu3@`lJfku5!GB~P&adQeBx^K_5LkVKMY(bUl>#py9>zn?gVpzKJ9n#j>*ha%*kQHwBYr_&yk6u&bUTZR|; z(sEAls24o@nBWu~C3nQw?gI6)4t8RZbs#U%lr?-0#8Q3F^_9KH8hB^**G}VMv9net z4POpv#U|GSRr@b&Bk39lLZ|Y?XTdPijY(Qbr2a05KDb38Ls%aJ+1Ow`$S+uCb2Pb?gK=L|yt8O0> z=^tS}b4e?FOwFl}gq*G+BitWuzIudJ0T;2)d!&`y*GBXva&+Wp8EO?HKUKq=x?(g3 z%WCua;jZg)(B^xI1wMt7L%`g;+lO^xSacON64?h_*&vCiBNixH#FMRvW@3~F47Ec8 ze~>+Z6_;BYSWK<>)hXw-qP#Aasi>vbm z^&;cE@5bHyND_{5EYP+*U^aEXQ;Gi@B~Il{4bqxs2}zhuqQA_jz5*x;Lr+ZpITic^ zYASG==l$8ZoanKpbN@oVv;d_aI_fq67#H}0cLFVZ13@ENCof(_>!rp+NC0V00&hYI z#Ju{mZFtz9qp0n-06Lt1;7Xm;8Vm^G?2i0sz1QkbuZJfflKq3N28;R*4wO`_H~bak=qoAqWLI z@J`ftg|%2n%JP92%r#2PNWNwyC1nT0O@%p$X=KYLPK+s0@aO;J12@K1lS=;2%iWu-BvnOjq#e8G>*aK$NQz zA3iU`Q*NjV`I^n*hYx$R_Hje4@LVf$fEs|K+M9%KM0;GM{VFf0`Kfvf@CK6Ta-DMl zMe`hh{Tjv@ikXt$ABOkzvW0M>tTXjIqd1viB>xF7{?Kjs2RZbsvmS&y-Qov8Rral4 zL4?FRlmL5p#z?J`|jyrg>u@=!uPHXyWJ8F-$03)}1`I zffp`+4{Dtc&<$tjGX{Va0k_FH*F6t7bcvPEy4j67({y`&&StsHmW#WHVo%h%WGa#a zIv$Pbp}kCd7>>M)X!tF5UT!>}=+@=@FvtapL5_~FPLwL{^)W#{m@uClmL2BH@09W^ z_#bDk>i}dGW2;55`s)FI-8Lr^0Ptb)@hg4@5z1M$VM@jcc=v(_urzZ35+nqygQbY? zw1Zvyp}GJaG0$=|BHp6>kDg++5?c7>8E7NKI5LI0lt#)Ib>TH1su7^DSC)^KqMzA4 zjX*ot@Yy*awQs*J^qI|O!PzCCzd8A>jc`P%ZdMV~)mdPuqQH?`(Fg9#dEf%G^Q-C6uT8bYU$YE;^LH5PQx z@)6)r5tOwCnq3ev?Ooj(n6KBsSkr{SNJ8v#)@-J_qpdG-SU!>;<3kyhMRo5#M}-lb z3GjicjbY~z%1s(6ro5`Ym3K9;`4b8;D>&=hIbUR3SYtQ~w7uYa&-sz!K@OXW)4=`^ z4bkU+dPAvI1eNF4gedbq!klLTkZp!;-Sx*UP?6==j~}X*HBx7a6b+kI5)76BL1hq~ zm;-5<_@~}C8Qd$hT_7o@HIKjY%ZQL*xQ4d#3;l`YMHX?it>WZrXMauspKX95mJh)K z`-_az^~;>D_ve@SIcnR6_faV>U6(S~9jb#4gp{gRsX8;~pPwReXr?>vNu@5!%fcU= zJxPR%aJ8cjaH^*morc7L%!h^?BUun-M>yWoy!cJ#1XUnm!0y89{nmOij$}&Cn|se0 ztPF8yqzI6L&ChuS6m8#*G=OktLPoCXjF30?7=xAAamHi@`9v52I(!MbJsMPA^H90v!wv8Y_ipa7I0pMy2QRxd}L{$}ihOjWggHCy<_pU8H)xKNz31aC~vPGW#km_*lI$1W965OApi>afLwAS7hzHj`Y8IawQC=e;oLP;i3WYPf&prxT2I-ut;(_y8MfiyhT@a$%L*h_ z1Kb(bnbZSZN)h+ESyahf-JqF|OZ&}quL#GePCorP%X?=1;R7>~uP0k}*dV+BQr@or z{t!Pm-`rip+DWc_Y%z44#@T@QC_3+Pjm}D_1&qc0hqiXQRle-kDCQK-8|+F$#9zi~ zb|CR4b^H(qQAmK?*@Gc*6=#wryrp%Tb{Fn;P9Vzy2Yq!M=<;An1}K#bUOZHG;O#U= zzxWL;dqn;$1 z1#qB8mm`8F5FbtRw_|)p0rkD?;ZjD_*53g5c;2RUe^|y9u&p~L|0EYeRt;7M3c>a6BVr3g^h2JprWl|Y^b1058%N=q@`cZ}5PaS_i&Nj@=Cu=d4KPAEFkYuySJp%x z@W~o@s=9(cgx(Ky?7ABkrH z!1o#b;b-<(*C#~wZ9PcI%NFhovBgogqbWUFFW)Kts2gUd{ zu#)42RY4H}EMw$D;VZ);o94V(=d9i%U^DnsJ476Tr zxg^<9y;a3rMd1EBeX;ge*qOZqWNDPsT$81g9j_INfsHtDqiE|g(ui63qM!ZG(~1<| zHPWB(7b|CdC)c3|xZH2%{&qZ1uXViUTp>4_SD3lrK-7!&AVKaaU6zf3OxwVRsW%{U LYO+O7UIzXLzq`2h From 0d49b7154437715d7d16a10eaa0c2c36b5b13c7a Mon Sep 17 00:00:00 2001 From: Aleksey Novikov Date: Wed, 18 Sep 2024 12:51:25 +0300 Subject: [PATCH 4/4] remove creator test for panel title observability --- testCafe/property-grid/panels.ts | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/testCafe/property-grid/panels.ts b/testCafe/property-grid/panels.ts index 36b30669c..619684d78 100644 --- a/testCafe/property-grid/panels.ts +++ b/testCafe/property-grid/panels.ts @@ -50,27 +50,3 @@ test("Panel stay focused on question change", async (t) => { .click(question1) .expect(Selector("div [data-name=\"minWidth\"] input").focused).ok(); }); -test("Show/hide panel header on entering/deleting the panel title, Bug#5720", async (t) => { - const json = { - elements: [ - { - type: "panel", - name: "panel1" - } - ] - }; - const panel = Selector(".svc-panel__placeholder"); - const hiddenPanelTitle = Selector(".sd-element__title--hidden"); - const titleEditor = Selector("[data-name='title']").find("textarea"); - await setJSON(json); - await t - .click(panel) - .expect(hiddenPanelTitle.exists).ok() - .click(titleEditor) - .typeText(titleEditor, "MyTitle") - .expect(hiddenPanelTitle.exists).notOk() - .expect(Selector(".sv-string-editor").withText("MyTitle").exists).ok() - .selectText(titleEditor) - .pressKey("delete") - .expect(hiddenPanelTitle.exists).ok(); -});