Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslintrc do not support json5 #88

Closed
aladdin-add opened this issue Aug 24, 2018 · 1 comment
Closed

eslintrc do not support json5 #88

aladdin-add opened this issue Aug 24, 2018 · 1 comment

Comments

@aladdin-add
Copy link

https://github.com/survivejs/maintenance-book/blob/master/manuscript/code-quality/01-linting.md#eslint-configuration-formats

.eslintrc support some json5 features.(like single-quoted string, unquoted object keys). but it has been deprecated (https://eslint.org/docs/user-guide/configuring#configuration-file-formats)
@sapegin
Copy link
Member

sapegin commented Aug 24, 2018

Yup, we should update it to .eslintrc.json.

sapegin added a commit that referenced this issue Sep 8, 2018
@sapegin
Use ".eslintrc.json" because ".eslintrc" is deprecated
139452c 
Fixes #88
@sapegin sapegin mentioned this issue Sep 8, 2018
Merged
@bebraw bebraw closed this as completed in #90 Sep 9, 2018
bebraw pushed a commit that referenced this issue Sep 9, 2018
@sapegin @bebraw
Use ".eslintrc.json" because ".eslintrc" is deprecated (#90)
7a4c87b 
Fixes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sapegin @aladdin-add