calendarPlot: Jan and Dec plots are not proper

[Tanvi-Jain01]

Jan and Dec plots aspect ratio is incorrect

While exploring this package I tried calendarPlot, and the plot for January and December was not correct. (The beginning days of Jan and Dec is wrong) Also, the plot for Jan and Dec is same, which isn't possible.

Code:

import numpy as np
import pandas as pd
np.random.seed(42)  

start_date = pd.to_datetime('2022-01-01')
end_date = pd.to_datetime('2022-12-31')

dates = pd.date_range(start_date, end_date)

pm25_values = np.random.rand(365)  # Generate 365 random values
ws_values = np.random.rand(365)
wd_values = np.random.rand(365)


df = pd.DataFrame({
    'date': dates,
    'pm25': pm25_values,
    'ws': ws_values,
    'wd': wd_values
})

df['date'] = df['date'].dt.strftime('%Y-%m-%d')  # Convert date format to 'YYYY-MM-DD'

from vayu.calendarPlot  import calendarPlot
calendarPlot(df, 'pm25', '2022','India')`

Output:

Source Code:

vayu/vayu/calendarPlot.py

Lines 114 to 133 in ef99aef

	while t <= 12:
	avg_ws = []
	avg_wd = []
	avg_pm25 = []
	df_year_1 = df_year[df_year.month == t]
	avg_wd = df_year_1["wd"]
	avg_ws = df_year_1["ws"]
	avg_pm25 = df_year_1[pollutant]
	i = 1
	a = 0
	b = len(avg_pm25)
	while i <= 1:
	data = avg_pm25[a:b]
	num = len(data)
	if t == 12:
	start = dt.datetime(int(year), 1, 1)
	else:
	start = dt.datetime(int(year), t, 1)

Explaination:

while t <= 12:
           ...
     while i <= 1:
         ...
      if t == 12:
       start = dt.datetime(int(year), 1, 1)

Here, first 1 represents the month value, second 1 represents the day value.
In this case, month value is hardcoded as 1, indicating January for December plot,

Solution:

Hence, month value 1 should be replaced with t

Additionally, we don't require while i <= 1: this while loop, as we already have a parent while loop which is while t <= 12:

[patel-zeel]

@Tanvi-Jain01 Please refer to this link: https://sustainability-lab.github.io/vayu/examples/nbs/calendarPlot.html

If there was an issue with the code, we should have seen the same issue in the above link. So, something else might also be the root cause.

[patel-zeel]

@nipunbatra Here is another library with a nice calendar plot: july. @Tanvi-Jain01 We may adapt some features from there.

Two months plot	Year Plot