Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Missing pronunciations in Chinese #81

Open
claw89 opened this issue Jan 20, 2021 · 1 comment · May be fixed by #85
Open

Missing pronunciations in Chinese #81

claw89 opened this issue Jan 20, 2021 · 1 comment · May be fixed by #85

Comments

@claw89
Copy link

claw89 commented Jan 20, 2021

Links to pronunciation audio files are not returned when searching for Chinese words (using Han characters). For example the following code:

word = parser.fetch('朋友', 'chinese')
for item in word:
    print(item['pronunciations'])

returns

{'text': ['朋友\n', '朋友\n'], 'audio': []}

This appears to be because pronunciations for Chinese words are placed inside

<div class="vsSwitcher" data-toggle-category="pronunciations"></div>

whereas those for English are in

<table class="audiotable"></table>

This may be related to #9

@suyashb95
Copy link
Owner

@claw89 thank you for pointing this out and debugging! I'm not working on this parser atm so can't really fix this right now but, a pull request for this would be helpful

@claw89 claw89 linked a pull request May 1, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants