Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline dependencies of docker CI images #750

Closed
gonuke opened this issue Jul 8, 2021 · 3 comments · Fixed by #951
Closed

Streamline dependencies of docker CI images #750

gonuke opened this issue Jul 8, 2021 · 3 comments · Fixed by #951
Assignees

Comments

@gonuke
Copy link
Member

gonuke commented Jul 8, 2021

A review of the the dependencies, esp. apt-get and pip, that are included for CI images in order to minimize the size and communicate the true dependency list.

The current CI docker images install some libraries that may no longer be necessary (e.g. BLAS/LAPACK).

@ahnaf-tahmid-chowdhury
Copy link
Member

Still it's an issue?

@gonuke
Copy link
Member Author

gonuke commented Feb 16, 2024

I think it is an issue. For example, we install HDF5 libraries even though we build our own HDF5 every time (unless we pursue #608). It would be great to remove any packages we don't need. This would probably be a matter of manually testing our Dockerfile with individual packages removed and see if it works, one at a time.

@ahnaf-tahmid-chowdhury
Copy link
Member

To work on this, we need to enable all of the options. BUILD_MCNP5 or BUILD_MCNP6, BUILD_MCNP_PLOT, BUILD_MCNP_OPENMP, BUILD_MCNP_MPI, BUILD_MCNP_PYNE_SOURCE, BUILD_STATIC_LIBS, BUILD_STATIC_EXE, BUILD_PIC, BUILD_FLUKA, DOUBLE_DOWN, BUILD_CI_TESTS are needed to be turned on.

I have noticed #677 is working on FLUKA build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants