Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no way to exclude peerDependencies when using package-lock.json #253

Open
AumyF opened this issue Aug 11, 2021 · 1 comment · May be fixed by #254
Open

There is no way to exclude peerDependencies when using package-lock.json #253

AumyF opened this issue Aug 11, 2021 · 1 comment · May be fixed by #254

Comments

@AumyF
Copy link

AumyF commented Aug 11, 2021

Without the option --lock, node2nix ignores peerDependencies by default and we can include them by setting --include-peer-dependencies explicitly.

However, when using --lock, node2nix includes peerDependencies by default and there is no way to make it ignore them.
AumyF added a commit to AumyF/node2nix that referenced this issue Aug 11, 2021
@AumyF
Fix svanderburg#253: exclude peerDependencies by default even using '…
29b3b0c 
…--lock' flag
@AumyF AumyF linked a pull request Aug 11, 2021 that will close this issue
Open
@svanderburg
Copy link
Owner

Yes, I've explained the rationale in the pull request -- it's because the option is used by node2nix's implementation of the dependency resolution algorithm. Maybe the documentation can be adjusted to make this more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #253: exclude peerDependencies by default even using '--lock' flag AumyF/node2nix
2 participants
@svanderburg @AumyF