Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons in the TypeScript plugin modal completely cover the source #2646

Closed
ivanesmantovich opened this issue Jan 3, 2025 · 0 comments · Fixed by #2647
Closed

Buttons in the TypeScript plugin modal completely cover the source #2646

ivanesmantovich opened this issue Jan 3, 2025 · 0 comments · Fixed by #2647
Labels
bug Something isn't working

Comments

@ivanesmantovich
Copy link
Contributor

Describe the bug

Buttons in the "The Svelte for VS Code extension now contains a TypeScript plugin..." modal completely cover the Source

Reproduction

  1. Close the currently open project (if you have one)
  2. Remove the svelte.enable-ts-plugin setting from settings.json
  3. Open any Svelte project
  4. Open any .svelte file
  5. The modal should appear

Expected behaviour

The user can see the Source of the modal, at least partially (that way he can hover and see the full Source in the tooltip)

System Info

  • OS: Darwin arm64 24.2.0
  • IDE: VSCode 1.96.2 (Universal)
  • Svelte for VS Code: 109.4.0

Which package is the issue about?

Svelte for VS Code extension

Additional Information, eg. Screenshots

1
@ivanesmantovich ivanesmantovich added the bug Something isn't working label Jan 3, 2025
ivanesmantovich added a commit to ivanesmantovich/language-tools that referenced this issue Jan 3, 2025
@ivanesmantovich
fix: source of the TypeScript plugin modal is now visible (sveltejs#2646
21bc25a 
)
@ivanesmantovich ivanesmantovich mentioned this issue Jan 3, 2025
Merged
dummdidumm pushed a commit that referenced this issue Jan 6, 2025
@ivanesmantovich
fix: reword plugin modal options (#2646) (#2647)
477e76d 
In accordance with VS Code style guidelines + shorter so you can see the source

Fixes #2646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: source of the TypeScript plugin modal is now visible ivanesmantovich/language-tools
1 participant
@ivanesmantovich