Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries that utilize monorepos don't have their svelte dependencies replaced during tests #14

Open
AdrianGonz97 opened this issue Jan 5, 2024 · 1 comment

Comments

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Jan 5, 2024

While investigating #13, I noticed that libraries who utilize monorepos aren't getting their svelte dependencies (like @sveltejs/kit) replaced. e.g. Skeleton and Melt both use SK v1, yet Melt fails and Skeleton does not.

Here are two more libraries that I used to test locally to confirm (they both also use SK v1):

Test for bits-ui (normal repo, fails):

// bits-ui.ts
import { runInRepo } from '../utils'
import { RunOptions } from '../types'

export async function test(options: RunOptions) {
	await runInRepo({
		...options,
		repo: 'huntabyte/bits-ui',
		branch: 'main',
		test: 'pnpm test',
	})
}

Test for svelte-ux (monorepo, passes):

// svelte-ux.ts
import { runInRepo } from '../utils'
import { RunOptions } from '../types'

export async function test(options: RunOptions) {
	await runInRepo({
		...options,
		repo: 'techniq/svelte-ux',
		branch: 'main',
		test: 'pnpm test:unit',
	})
}
@dominikg
Copy link
Member

dominikg commented Feb 4, 2024

if you want other dependencies besides svelte itself overridden (eg sveltekit, vite-plugin-svelte) you have to add them as overrides. Available overrides are defined in the builds directory

https://github.com/sveltejs/svelte-ecosystem-ci/tree/main/builds

how do use them can be seen here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants