-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile errors when typechecking svelte.config.js
with moduleResolution
set to nodenext
#591
Comments
minimized comment, off topic
this also causes two even more severe issues: compile errors when trying to import another svelte component<script lang='ts'>
import Foo from './Foo.svelte' // svelte file that exists
</script>
<Foo/>
also why is an undefined variable only a warning instead of an error? runtime crashattempting to run my app with
|
Could you provide a reproduction for this? This sounds a bit unrelated - moduleResolution shouldn't have impact on how things are resolved at runtime, unless Vite is doing something funky there. |
yeah i can't reproduce that anymore updating to typescript 5, must've been the same issue as #612 however the issue in the OP still occurs |
Fixed as part of #640 |
I'm still getting it src/internal/configurations.js:12:14 - error TS2349: This expression is not callable.
Type 'typeof import("/home/alex/git/@aa/js-tooling/node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/svelte-preprocess/dist/index")' has no call signatures.
12 preprocess: sveltePreprocess(),
~~~~~~~~~~~~~~~~ When trying to import the default import. import { default as sveltePreprocess } from 'svelte-preprocess';
/**
* @type {import('./types.js').Config}
*/
export const libConfiguration = {
preprocess: sveltePreprocess(),
}; I think this happened before import { sveltePreprocess } from 'svelte-preprocess/dist/autoProcess.js'; But I can no longer do this (since the exports object was defined in this versions package.json) src/internal/configurations.js:4:34 - error TS2307: Cannot find module 'svelte-preprocess/dist/autoProcess.js' or its corresponding type declarations.
4 import { sveltePreprocess } from 'svelte-preprocess/dist/autoProcess.js';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Relevant TSConfig: {
"compilerOptions": {
"moduleResolution": "NodeNext",
"module": "NodeNext"
}
} It would be nice to just have this export also exported as a named export. Default exports are such a headache sometimes..
For now I can just |
If you do |
This deprecates the default export in favor of the new named export `sveltePreprocess`. It's done to ensure a better interop between CJS and ESM without resorting to hacks in the future. It also enables people using `"module": "NodeNext"` in their `tsconfig.json` to import without type errors. The sub exports were also adjusted so that the transpiled TS output doesn't include `__importDefault` wrappers, which makes Node's static analysis miss those named exports. Related: #591
In 6.0.1 you can now do |
Describe the bug
when typechecking
svelte.config.js
withmoduleResolution
set tonodenext
, the following compile errors occur:Logs
Please include browser console and server logs around the time this bug occurred.
To Reproduce
dev
npm script to finishExpected behavior
A clear and concise description of what you expected to happen.
Information about your project:
svelte-preprocess
version: 5.0.3Additional context
other related issues:
svelte.config.js
withmoduleResolution
set tonodenext
vite-plugin-svelte#619svelte.config.js
withmoduleResolution
set tonodenext
kit#9663The text was updated successfully, but these errors were encountered: