Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios safearea4 #17

Closed
2 tasks done
cparello opened this issue Nov 5, 2024 · 8 comments
Closed
2 tasks done

ios safearea4 #17

cparello opened this issue Nov 5, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@cparello
Copy link

cparello commented Nov 5, 2024

Before submitting a new issue

  • I tested using the latest release of the library, as maybe the bug has been already fixed.
  • I checked for possible duplicate issues, with possible answers.

Bug summary

simulator_screenshot_B39654C1-F965-49CE-9807-1AA436D2E9FC
no matter what i do the browser doesnt look like the screenshot on github. where the browser top bar is below the status bar notch area on ios

Library version

4

Environment info

ios 18 simulator

Steps to reproduce

i am wrapping a touchableopacity in safeareaview and clicking the button

Reproducible sample code

openBrowser(url, {
            animationType: "slide", // "fade" | "slide" (default to "slide")
            dismissButtonStyle: "close", // "cancel" | "close" | "done" (default to "close")
            barTintColor:  '#6d6fd5', // in-app browser UI background color
            controlTintColor: "#000", // in-app browser buttons color
            onOpen: () => {
                smartyLogger("openBrowser onOpen");
                // fired on browser opened
                // useful to switch the StatusBar color, for example
            },
            onClose: (url) => {
                // fired on browser closed
                // url will be defined if the browser has been closed via deeplink
            },
        }).catch((error) => {
            console.error(error);
        });
@cparello cparello added the bug Something isn't working label Nov 5, 2024
@cparello
Copy link
Author

cparello commented Nov 5, 2024

i need it to look like thisimage

@zoontek
Copy link
Contributor

zoontek commented Nov 5, 2024

Which simulator are you using? iPhone? Which model?

@dirkpostma
Copy link

Same issue here.

  • react-native 0.74.5
  • iOS simulator 18+, iPhone 16 (probably alld evices)

Simulator with iOS 17: no issue

Other libraries seem to have similar issiues, e.g.
FormidableLabs/react-native-app-auth#1026

@cparello
Copy link
Author

Which simulator are you using? iPhone? Which model?
sorry i was using ios 18, model didnt matter

@zoontek
Copy link
Contributor

zoontek commented Nov 27, 2024

Just tried it with iOS 18.1, iPhone 16 pro simulator, no issue (even with your code / your colors):

Screenshot 2024-11-27 at 10 20 39

Did you tried on a fresh project? If you can provide a repository to easily reproduce the issue, that would be great.

@dirkpostma
Copy link

@zoontek which xCode version do you have? Perhaps it only happens with xCode 16:

Xcode 16.0 + iOS 17.0 Simulator => No issue
Xcode 16.0 + iOS 18.0 Simulator => SafariViewController freezes
Xcode 16.0 + iOS 18.0 Real device => No issue

https://forums.developer.apple.com/forums/thread/764468

@zoontek
Copy link
Contributor

zoontek commented Nov 27, 2024

@dirkpostma Xcode 16.1

@zoontek
Copy link
Contributor

zoontek commented Jan 9, 2025

I'm closing this, had no solid reproduction.

@zoontek zoontek closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants