Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place all the confidential information in .environement variables #292

Open
harshakhmk opened this issue May 9, 2021 · 9 comments
Open
Labels
bug Something isn't working

Comments

@harshakhmk
Copy link

harshakhmk commented May 9, 2021

Describe the bug

  • Emergency button is responding with 500 Internal Server Error and it is unable to send emails with bad credentials, I think we should handle the cases for not sending the emails and sending appropriate error messages for bad credentials.
  • Also storing all the credentials in the environment variables(in the .env file) would be safe.

Emergency Bug Image

@harshakhmk harshakhmk added the bug Something isn't working label May 9, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

Hi 😄, thanks for creating your first issue at RESCUE, do read and follow the Code of Conduct and the Contribution Guidelines while contributing. 🚀

@swapnilsparsh
Copy link
Owner

@harshakhmk You have to add your email and password in the mail.py file and set your Gmail account to enable less secure apps then this will resolve.
If you have done this and then also it's showing, then please let me know.

@harshakhmk
Copy link
Author

As I mentioned, we can have a .env file where it would be storing all the email and passwords and other confidential information and we can handle the cases where the required field is empty or invalid, by raising error messages and only send emails when all the credentials are valid, so that load on the sending the mails will be less and that will solve the scalability issues, as Gmail SMTP server can send 500 emails per day when logged into their web interface.
Also, It would be good enough if Rescue Team has its own email, and sending emails from it seems more reasonable

@coding-geek21
Copy link
Contributor

@harshakhmk You have to add your email and password in the mail.py file and set your Gmail account to enable less secure apps then this will resolve.
If you have done this and then also it's showing, then please let me know.

Emergency functionality is working fine

@swapnilsparsh
Copy link
Owner

As I mentioned, we can have a .env file where it would be storing all the email and passwords and other confidential information and we can handle the cases where the required field is empty or invalid, by raising error messages and only send emails when all the credentials are valid, so that load on the sending the mails will be less and that will solve the scalability issues, as Gmail SMTP server can send 500 emails per day when logged into their web interface.
Also, It would be good enough if Rescue Team has its own email, and sending emails from it seems more reasonable

Do you want to work on this issue then please rephrase the issue and then let me know?

@harshakhmk
Copy link
Author

As I mentioned, we can have a .env file where it would be storing all the email and passwords and other confidential information and we can handle the cases where the required field is empty or invalid, by raising error messages and only send emails when all the credentials are valid, so that load on the sending the mails will be less and that will solve the scalability issues, as Gmail SMTP server can send 500 emails per day when logged into their web interface.
Also, It would be good enough if Rescue Team has its own email, and sending emails from it seems more reasonable

Do you want to work on this issue then please rephrase the issue and then let me know?

Yeah I would like to work on this issue, where the rephrased issue is place all the confidential information in .env file

@harshakhmk harshakhmk changed the title Emergency functionality is not working Place all the confidential information in .environement variables May 11, 2021
@swapnilsparsh swapnilsparsh added gssoc21 GirlScript Summer of Code 2021 Level2 Bug fixing, adding small features. labels May 12, 2021
@harshakhmk
Copy link
Author

Why EMAIL_BACKEND EMAIL_HOST EMAIL_PORT EMAIL_USE_TLS EMAIL_HOST_USER EMAIL_HOST_PASSWORD
DEFAULT_FROM_EMAIL are declared 2 times?

@swapnilsparsh
Copy link
Owner

Why EMAIL_BACKEND EMAIL_HOST EMAIL_PORT EMAIL_USE_TLS EMAIL_HOST_USER EMAIL_HOST_PASSWORD
DEFAULT_FROM_EMAIL are declared 2 times?

Can you please specify the file where it is specified two times?

@harshakhmk
Copy link
Author

harshakhmk commented May 14, 2021

Why EMAIL_BACKEND EMAIL_HOST EMAIL_PORT EMAIL_USE_TLS EMAIL_HOST_USER EMAIL_HOST_PASSWORD
DEFAULT_FROM_EMAIL are declared 2 times?

Can you please specify the file where it is specified two times?

in mysite/settings.py
I have created a PR 302 review it @swapnilsparsh

@swapnilsparsh swapnilsparsh removed Level2 Bug fixing, adding small features. gssoc21 GirlScript Summer of Code 2021 labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants