You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow-up ticket for the v2 implementation of the radio-button which could not be completed due to several challenges encountered during the development process. This ticket aims to document these issues and provide a clear path forward for completing the implementation.
Current Issues
Design-Code Inconsistencies: The figma implementation uses a padding to move the label text to the right beside the radio-button. This approach can not be used in code. Currently it is handled differently which means the padding token can not be utilized. To be able to tokenize the spacing between the button and the label, the structure of the design has to be adapted.
Missing Tokens: Some values like the the border-radius of the focus outline (the radius of the form-check element) or the radio select do not have associated tokens. It's not clear if these should be added or use hardcoded values.
Validation Implementation: The form-validation design has changed. Should the validation styles be implemented individually for each component (and thus use tokens) or should the existing form-validation file be adapted to fit the new design?
needs: discussionThere is at least one topic in the pattern descussion meeting about the issue
Tasks
Have discussion on validation implementation, make decision and document it
Review v2 design and code structure
Document inconsistencies and discuss with designers
schaertim
added
📦 styles
Related to the @swisspost/design-system-styles package
and removed
📦 components
Related to the @swisspost/design-system-components package
labels
Sep 26, 2024
Description
Background
This is a follow-up ticket for the v2 implementation of the radio-button which could not be completed due to several challenges encountered during the development process. This ticket aims to document these issues and provide a clear path forward for completing the implementation.
Current Issues
form-validation
file be adapted to fit the new design?needs: discussion
Tasks
Design
https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=426-2188
Tokens
Due to the issues described above, not all tokens were able to be used. Here is a list of all tokens not yet used:
The text was updated successfully, but these errors were encountered: