Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foundations]: Typography > Paragraph #3416

Open
3 of 6 tasks
Cian77 opened this issue Aug 20, 2024 · 2 comments · May be fixed by #3569
Open
3 of 6 tasks

[foundations]: Typography > Paragraph #3416

Cian77 opened this issue Aug 20, 2024 · 2 comments · May be fixed by #3569
Assignees
@bashirkarimi
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
Cargo Components

Comments

@Cian77
Copy link

Cian77 commented Aug 20, 2024 •
edited
Loading

Description

Implement default styles paragraphs.

Open issues:

Design:

  • Integrated new typography
  • Spacing is defined
  • Documentation final

Tokens:

  • Typography tokens ready

Design

https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=26-49

Tokens

  • Tokens for this component are ready

Proposed markup

<p class="lead">This is a lead text</p>

<!-- With tokens, paragraphs in different dimensions will have different sizes -->
<p>This is a default paragraph (medium)</p>

<!-- Don't implement size variants for large or small paragraphs. Font size for other use cases will be determined by either the wrapping component or utility classes -->

Tasks

💻 Tasks
Beta Give feedback
  2. [foundations]: Body base styles #3496
    2 of 3
    ❇️ good first issue 📦 styles
    bashirkarimi
@Cian77 Cian77 added the 📦 components Related to the @swisspost/design-system-components package label Aug 20, 2024
@Cian77 Cian77 added this to the Design v2 milestone Aug 20, 2024
@gfellerph gfellerph added needs: refinement 📦 styles Related to the @swisspost/design-system-styles package and removed needs: refinement 📦 components Related to the @swisspost/design-system-components package labels Aug 20, 2024
@Cian77 Cian77 changed the title [component]: Lead & Paragraph [foundations]: Lead & Paragraph Aug 26, 2024
@Cian77 Cian77 changed the title [foundations]: Lead & Paragraph [foundations]: Typography > Lead & Paragraph Aug 26, 2024
@bashirkarimi bashirkarimi self-assigned this Sep 11, 2024
@oliverschuerch
Copy link
Contributor

@bashirkarimi Take care! As far as I understand, we decided paragraph tyles will end up in a elements/paragraph.scss while lead styles will end up in components/lead.scss.
Maybe we should split this tickets into two different tickets.

@oliverschuerch
Copy link
Contributor

I have just added another ticket for the lead text component: #3546

@oliverschuerch oliverschuerch changed the title [foundations]: Typography > Lead & Paragraph [foundations]: Typography > Paragraph Sep 16, 2024
@oliverschuerch oliverschuerch mentioned this issue Sep 16, 2024
Closed
4 tasks
@bashirkarimi bashirkarimi linked a pull request Sep 23, 2024 that will close this issue
feat: add paragraph style #3569
Open
@gfellerph gfellerph modified the milestones: Design v2, Cargo Components Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bashirkarimi bashirkarimi

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 🤬 Dev in review
Milestone
Cargo Components
4 participants
@gfellerph @oliverschuerch @bashirkarimi @Cian77