Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent dir items shake when redraw #1859

Open
3 tasks done
aidancz opened this issue Oct 30, 2024 · 4 comments
Open
3 tasks done

parent dir items shake when redraw #1859

aidancz opened this issue Oct 30, 2024 · 4 comments
Labels
bug Something isn't working cant reproduce The issue cannot be reproduced as described

Comments

@aidancz
Copy link
Contributor

aidancz commented Oct 30, 2024

What system are you running Yazi on?

Linux X11

What terminal are you running Yazi in?

st 0.8.5

yazi --debug output

Yazi
    Version: 0.3.3 (5eabd7d 2024-10-29)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.3 (Arch Linux 2024-09-05)

Emulator
    Emulator.via_env: ("st-256color", "")
    Emulator.via_csi: Ok(Unknown([]))
    Emulator.detect : Unknown([])

Adapter
    Adapter.matches: X11

Desktop
    XDG_SESSION_TYPE           : Some("tty")
    WAYLAND_DISPLAY            : None
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL              : Some("/usr/bin/zsh")
    EDITOR             : Some("nvim")
    VISUAL             : Some("nvim")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default     : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-create: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-rename: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : tmux 3.5a
    tmux build flags   : enable-sixel=Unknown
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : 2.9.6
    ffmpegthumbnailer: 2.2.3
    magick           : 7.1.1-39
    fzf              : 0.55.0
    fd               : 10.2.0
    rg               : 14.1.1
    chafa            : 1.14.2
    zoxide           : 0.9.6
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1


--------------------------------------------------
When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time.
You can find it in the "/home/aidan/.local/state/yazi" directory.

Describe the bug

parent dir items shake when redraw

20241030-003130-853126.mp4
keys in the video above:

super + space: open terminal
super + 0: close window
ctrl + d: quit shell

note the different behavior of "close window" and "quit shell"

Minimal reproducer

I can only reproduce it in my home directory

Anything else?

no

Validations

  • I tried the latest nightly build, and the issue is still reproducible
  • I updated the debug information (yazi --debug) input box to the nightly that I tried
  • I can reproduce it after disabling all custom configs/plugins (mv ~/.config/yazi ~/.config/yazi-backup)
@aidancz aidancz added the bug Something isn't working label Oct 30, 2024
@sxyazi
Copy link
Owner

sxyazi commented Oct 30, 2024

I can't reproduce it:

screenshot-002087.mp4
yazi --version
Yazi 0.3.3 (a8bd21ad 2024-10-30)

kitty -v
kitty 0.36.4

@sxyazi sxyazi added cant reproduce The issue cannot be reproduced as described waiting on op Waiting for more information from the original poster labels Oct 30, 2024
@aidancz
Copy link
Contributor Author

aidancz commented Nov 1, 2024

Yazi 0.3.3 (0baccdc 2024-11-01)

More detailed information:

  1. This only happens when the home directory (~) is the parent directory, I even copied the home directory but the problem didn't happen:
20241102-012241-774060.mp4
  1. behavior:
  • When I close the window, the parent directory re-renders as if it were the current directory and a new window has been opened, but it shouldn't
  • When I open the window, the parent directory re-renders as if it were the current directory and a new window has been closed, but it shouldn't

Please compare:

20241102-012852-916924.mp4

scrolloff = 0

and

20241102-012949-752084.mp4

scrolloff = 0


Please compare:

20241102-015845-221078.mp4

scrolloff = 2

and

20241102-015722-419265.mp4

scrolloff = 2

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label Nov 1, 2024
@sxyazi
Copy link
Owner

sxyazi commented Nov 2, 2024

Unfortunately I still can't reproduce it even when I set the parent directory to $HOME (~), and I also tried setting scrolloff = 0, scrolloff = 2, scrolloff = 5 (default) in turn doesn't make any difference either

Can you try to debug it a bit?

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label Nov 2, 2024
@aidancz
Copy link
Contributor Author

aidancz commented Nov 3, 2024

okay

finally...


this issue is about zsh and HISTFILE

to reproduce it, please append this line to your .zshrc file

HISTFILE=$HOME/history

HISTFILE=$HOME/history:

20241103-133753-599383.mp4

HISTFILE=$HOME/Downloads/history:

20241103-133953-686484.mp4

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cant reproduce The issue cannot be reproduced as described
Projects
None yet
Development

No branches or pull requests

2 participants