Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature requests #51

Open
37 of 59 tasks
sxyazi opened this issue Aug 12, 2023 · 175 comments
Open
37 of 59 tasks

Feature requests #51

sxyazi opened this issue Aug 12, 2023 · 175 comments

Comments

@sxyazi
Copy link
Owner

sxyazi commented Aug 12, 2023 •
edited
Loading

Bugs

  • Exit selection mode on leave
  • Exit selection mode on yank
  • Trigger Refresh manually when rename, create, in case notify-rs doesn't update in time
  • Precache n+1 pages of mimetype instead of n for the better experience
  • Image preview on node-pty based terminal, like Hyper canary and VSCode

Features
@sxyazi sxyazi pinned this issue Aug 12, 2023
This was referenced Aug 19, 2023
Closed
Closed
@maxzinkus

This comment was marked as resolved.

Sign in to view
@otakutyrant

This comment was marked as resolved.

Sign in to view
@asim215

This comment was marked as resolved.

Sign in to view
@otakutyrant

This comment was marked as resolved.

Sign in to view
@sxyazi

This comment was marked as resolved.

Sign in to view
@maxzinkus

This comment was marked as resolved.

Sign in to view
@otakutyrant

This comment was marked as resolved.

Sign in to view
@sxyazi

This comment was marked as resolved.

Sign in to view
@otakutyrant

This comment was marked as resolved.

Sign in to view
@sxyazi

This comment was marked as resolved.

Sign in to view
@otakutyrant

This comment was marked as resolved.

Sign in to view
@otakutyrant

This comment was marked as resolved.

Sign in to view
@sxyazi

This comment was marked as resolved.

Sign in to view
@otakutyrant

This comment was marked as resolved.

Sign in to view
@sxyazi

This comment was marked as resolved.

Sign in to view
@otakutyrant otakutyrant mentioned this issue Aug 24, 2023
Closed
@dan-da
Copy link

dan-da commented Sep 12, 2023

some feature requests:

  • a help screen to list key commands. (if not already existing)
  • onscreen indicator how to get to help screen. eg by pressing 'h' or '?' perhaps.
  • display contents of compressed files as if sub-directory. eg .zip, .tgz, etc.
  • preview for video files, eg .mp4. Could be static image or animation.
  • preview image for openoffice documents, eg .odt. (could be as simple as transform to pdf first)
  • preview image for latex documents.
  • load preview for a file/path passed as cli argument to yazi and cd to parent dir.
  • preview for .svg files
  • preview for .ps (postcript) files. (convert to pdf with ps2pdf?)
  • enter key should descend into directory.
  • pg-up, pg-down should move selection in files list.
  • copy, cut, paste of files to other directory. ctrl-c, ctrl-x, ctrl-v. like in a gui file manager.
  • key to change sort order
  • preview for markdown files (toggle between code view and rendered view)
  • .json file preview/highlighting
  • toggle between html code and preview, eg with lynx?

these are things I half hoped/expected might work as I tried out the program.

It is nice enough to want more. ;-)

@Eric-Song-Nop
Copy link
Contributor

some feature requests:

  • a help screen to list key commands. (if not already existing)
  • onscreen indicator how to get to help screen. eg by pressing 'h' or '?' perhaps.
  • display contents of compressed files as if sub-directory. eg .zip, .tgz, etc.
  • preview for video files, eg .mp4. Could be static image or animation.
  • preview image for openoffice documents, eg .odt. (could be as simple as transform to pdf first)
  • preview image for latex documents.
  • load preview for a file/path passed as cli argument to yazi and cd to parent dir.
  • preview for .svg files
  • preview for .ps (postcript) files. (convert to pdf with ps2pdf?)
  • enter key should descend into directory.
  • pg-up, pg-down should move selection in files list.
  • copy, cut, paste of files to other directory. ctrl-c, ctrl-x, ctrl-v. like in a gui file manager.
  • key to change sort order
  • preview for markdown files (toggle between code view and rendered view)
  • .json file preview/highlighting
  • toggle between html code and preview, eg with lynx?

these are things I half hoped/expected might work as I tried out the program.

It is nice enough to want more. ;-)

@dan-da Too many features are already implemented in yazi, make sure you go through the sample config for keymap and you will find many of them. Check what's already there before you really ask for a new feature.

@dan-da
Copy link

dan-da commented Sep 12, 2023

I built and ran the code and tried it out, and took the time to list my impressions. Every feature I listed is something that did not work for me. If there is some arcane way to make it work, that's fine, but it is not intuitive for me, and so that is feedback you can take or dismiss as you like. I've no idea what you mean about the 'sample config for keymap' and don't intend to investigate. As I said above, a simple onscreen indicator for how to get command-help would go a long way, but I don't see it, and the default key bindings are either not intuitive for me, or simply the expected functionality do not exist. I also highly doubt 'too many' features are implemented... seems an odd thing to say.

regardless this response to my feedback contribution does not encourage me to spend more time with this project.

@maxzinkus
Copy link

maxzinkus commented Sep 12, 2023 •
edited
Loading

It's important to remember that open-source software authors don't "owe" anything to the community. @sxyazi shared this great project with us, and got a ton of feature requests really quickly, which they've been handling with grace.

This is not, afaik, their full-time job. Please don't act entitled in a repo like this.

EDIT: and thank you to maintainers @Eric-Song-Nop as well!

@sxyazi
Copy link
Owner Author

sxyazi commented Sep 13, 2023

@maxzinkus @Eric-Song-Nop

Thank you for these kind words, they give me the motivation to keep going!

Hey @dan-da, the config files for Yazi is mentioned in README, and it contains all the features and keybindings, along with docs.

a help screen to list key commands. (if not already existing)

You can press ~ to view the help screen.

onscreen indicator how to get to help screen. eg by pressing 'h' or '?' perhaps.

Good idea, but TUI space is precious. I'd like to add it to the README.

display contents of compressed files as if sub-directory. eg .zip, .tgz, etc.

I have plans to add this, but I haven't had enough time to complete it.

preview for video files, eg .mp4. Could be static image or animation.

If you've installed ffmpegthumbnailer as per the README, this should work. Currently, it only supports static images; GIF support has been noted in this issue.

.json file preview/highlighting

If you've installed jq as per the README, this should work.

enter key should descend into directory.
copy, cut, paste of files to other directory. ctrl-c, ctrl-x, ctrl-v. like in a gui file manager.
pg-up, pg-down should move selection in files list.

Yazi uses Vim keybindings by default. If you're not comfortable with them, you can create your own config file and modify them as you like. Please refer to the README for config details.

key to change sort order

Here are the default sorting keys, but of course, you can modify them as you wish:

yazi/config/preset/keymap.toml

Lines 73 to 83 in cbe0fd5

# Sorting
{ on = [ ",", "a" ], exec = "sort alphabetical --dir_first", desc = "Sort alphabetically, directories first" },
{ on = [ ",", "A" ], exec = "sort alphabetical --reverse --dir_first", desc = "Sort alphabetically, directories first (reverse)" },
{ on = [ ",", "c" ], exec = "sort created --dir_first", desc = "Sort by creation time, directories first" },
{ on = [ ",", "C" ], exec = "sort created --reverse --dir_first", desc = "Sort by creation time, directories first (reverse)" },
{ on = [ ",", "m" ], exec = "sort modified --dir_first", desc = "Sort by modified time, directories first" },
{ on = [ ",", "M" ], exec = "sort modified --reverse --dir_first", desc = "Sort by modified time, directories first (reverse)" },
{ on = [ ",", "n" ], exec = "sort natural --dir_first", desc = "Sort naturally, directories first" },
{ on = [ ",", "N" ], exec = "sort natural --reverse --dir_first", desc = "Sort naturally, directories first (reverse)" },
{ on = [ ",", "s" ], exec = "sort size --dir_first", desc = "Sort by size, directories first" },
{ on = [ ",", "S" ], exec = "sort size --reverse --dir_first", desc = "Sort by size, directories first (reverse)" },

load preview for a file/path passed as cli argument to yazi and cd to parent dir.

Are you referring to yazi /your/path? If so, it is currently supported. You can see by running yazi --help.

preview for markdown files (toggle between code view and rendered view)

Markdown file preview is currently supported, but I'm not sure what you mean by "rendered view."

preview image for openoffice documents, eg .odt. (could be as simple as transform to pdf first)
preview image for latex documents.
preview for .svg files
preview for .ps (postcript) files. (convert to pdf with ps2pdf?)
toggle between html code and preview, eg with lynx?

These features will require Yazi's plugin system. I plan to invest time in developing the plugin system soon, allowing users to write their own plugins and supporting more file types.

@c02y
Copy link

c02y commented Sep 13, 2023 •
edited
Loading

Features request:

  1. be able to show only the middle column, like ranger's viewmode
  2. be able to make two tabs side-by-side (two tabs both only show the middle column)
  3. set the default sort type (alphabetical/created/modified/natural/size) when opening yazi
  4. when sorting the list, show the details(created/modfifed/size) of all the files/dirs in the list
  5. be able to show all the size/date for the files/dirs in the list
  6. be able to get size of current selected files/dirs or all the files/dirs in the list
  7. be able to show the index for the list (can be set by default)

image

@sxyazi

This comment was marked as outdated.

Sign in to view
@c02y

This comment was marked as outdated.

Sign in to view
@sxyazi

This comment was marked as outdated.

Sign in to view
@c02y

This comment was marked as outdated.

Sign in to view
@ctem

This comment was marked as resolved.

Sign in to view
@mcmoodoo
Copy link

@maxzinkus @Eric-Song-Nop

Thank you for these kind words, they give me the motivation to keep going!

Hey @dan-da, the config files for Yazi is mentioned in README, and it contains all the features and keybindings, along with docs.

a help screen to list key commands. (if not already existing)

You can press ~ to view the help screen.

onscreen indicator how to get to help screen. eg by pressing 'h' or '?' perhaps.

Good idea, but TUI space is precious. I'd like to add it to the README.

display contents of compressed files as if sub-directory. eg .zip, .tgz, etc.

I have plans to add this, but I haven't had enough time to complete it.

preview for video files, eg .mp4. Could be static image or animation.

If you've installed ffmpegthumbnailer as per the README, this should work. Currently, it only supports static images; GIF support has been noted in this issue.

.json file preview/highlighting

If you've installed jq as per the README, this should work.

enter key should descend into directory.
copy, cut, paste of files to other directory. ctrl-c, ctrl-x, ctrl-v. like in a gui file manager.
pg-up, pg-down should move selection in files list.

Yazi uses Vim keybindings by default. If you're not comfortable with them, you can create your own config file and modify them as you like. Please refer to the README for config details.

key to change sort order

Here are the default sorting keys, but of course, you can modify them as you wish:

yazi/config/preset/keymap.toml

Lines 73 to 83 in cbe0fd5

# Sorting
{ on = [ ",", "a" ], exec = "sort alphabetical --dir_first", desc = "Sort alphabetically, directories first" },
{ on = [ ",", "A" ], exec = "sort alphabetical --reverse --dir_first", desc = "Sort alphabetically, directories first (reverse)" },
{ on = [ ",", "c" ], exec = "sort created --dir_first", desc = "Sort by creation time, directories first" },
{ on = [ ",", "C" ], exec = "sort created --reverse --dir_first", desc = "Sort by creation time, directories first (reverse)" },
{ on = [ ",", "m" ], exec = "sort modified --dir_first", desc = "Sort by modified time, directories first" },
{ on = [ ",", "M" ], exec = "sort modified --reverse --dir_first", desc = "Sort by modified time, directories first (reverse)" },
{ on = [ ",", "n" ], exec = "sort natural --dir_first", desc = "Sort naturally, directories first" },
{ on = [ ",", "N" ], exec = "sort natural --reverse --dir_first", desc = "Sort naturally, directories first (reverse)" },
{ on = [ ",", "s" ], exec = "sort size --dir_first", desc = "Sort by size, directories first" },
{ on = [ ",", "S" ], exec = "sort size --reverse --dir_first", desc = "Sort by size, directories first (reverse)" },

load preview for a file/path passed as cli argument to yazi and cd to parent dir.

Are you referring to yazi /your/path? If so, it is currently supported. You can see by running yazi --help.

preview for markdown files (toggle between code view and rendered view)

Markdown file preview is currently supported, but I'm not sure what you mean by "rendered view."

preview image for openoffice documents, eg .odt. (could be as simple as transform to pdf first)
preview image for latex documents.
preview for .svg files
preview for .ps (postcript) files. (convert to pdf with ps2pdf?)
toggle between html code and preview, eg with lynx?

These features will require Yazi's plugin system. I plan to invest time in developing the plugin system soon, allowing users to write their own plugins and supporting more file types.

thank you. Hidden files visibility was a life changer for me. I use yazi a lot, but will now use it ALL the time!

@sxyazi sxyazi mentioned this issue Sep 18, 2024
Closed
3 tasks
@corigne
Copy link

corigne commented Oct 1, 2024

Is there any traction on animated gif support in image previews? A branch or PR I can looks at perhaps? Kitty has animation support built in from 0.2 onward, and I'm curious if anyone has taken a crack at it yet.

@itsmenewbie03
Copy link

Is it possible to have vim mode in the rename pop up?
In neo-tree inside nvim it has that feature.
Yazi Rename:
image
NeoTree Rename:
image

@Axlefublr
Copy link

Is it possible to have vim mode in the rename pop up? In neo-tree inside nvim it has that feature. Yazi Rename: image NeoTree Rename: image

The way I do that, is by selecting the current entry and pressing rename. Then it will appear in my editor. Although having this be possible in a more direct way would be way more convenient, I basically always want to rename in my editor.

@fmorroni
Copy link

fmorroni commented Oct 7, 2024

Is it possible to have vim mode in the rename pop up?
In neo-tree inside nvim it has that feature.
Yazi Rename:
image
NeoTree Rename:
image

I'm not sure what you mean, for me the rename pop up is already a vim input. Meaning if I press r over a file the rename pop up opens, it starts in insert mode but I can press escape and change to normal mode and move the cursor and delete with regular vim keybinds.

@itsmenewbie03
Copy link

@fmorroni I tested and can confirm that it does exactly go to normal mode when you hit Esc, however motions like df. doesn't seem to work, even diw.

@fmorroni
Copy link

fmorroni commented Oct 7, 2024

@fmorroni I tested and can confirm that it does exactly go to normal mode when you hit Esc, however motions like df. doesn't seem to work, even diw.

Yeah, it's a very limited vim implementation, but it's good enough for renaming a couple of files every now and then.

This was referenced Oct 16, 2024
Closed
Closed
@boydaihungst
Copy link
Contributor

boydaihungst commented Oct 18, 2024 •
edited
Loading

I implemented Truncate long filenames in the file list feature for this plugin. In case anyone needs it.
https://github.com/boydaihungst/relative-motions.yazi
Here is the result:
2024-10-18T22:22:33,441169661+07:00

@sxyazi
Copy link
Owner Author

sxyazi commented Oct 18, 2024

This looks amazing @boydaihungst!

Would you like to try porting it to Yazi's codebase?

@boydaihungst
Copy link
Contributor

All I do is modify Current:render, Entity:render, Entity:highlight, Entity:symlink.

The idea is: we sort all Entity children/components in 2 bucket: resizable (highlight with id = 4, symlink with id = 6) and unresizable component (the rest). Count used character length (width), total usable space and max width for each of resizable components. Do the math to resize them, truncate if overflowed.

The first Entity._children loop: run as normal to get width, total width, resizable component's width, unresizable's component's width.

  • I run every entity component render function (i.e. Entity:highlights) like normal, so I can get the width() of those component, total_length_resizable of all resizable components and total_length_unresizable of all unresizable components.
  • I also add some extra metadata into Entity._children
    • length(integer) is component's width
    • max_length (integer) is the maximum size this component can render before get truncated. 0 because we need to calculate it later after knowing total_length_unresizable and total_length_resizable.
    • resizable (boolean) flag to know which components are resizable

now Entity should looks like this:

Entity = {
	_inc = 1000,
	_children = {
		{ "space", id = 1, order = 1000 },
		{ "icon", id = 2, order = 2000 },
		{ "prefix", id = 3, order = 3000 },
		{ "highlights", id = 4, order = 4000, resizable = true, length = xxx (integer), max_length = 0 (integer)  },
		{ "found", id = 5, order = 5000 },
		{ "symlink", id = 6, order = 6000, resizable = true, length = xxx (integer), max_length = 0 (integer)   },
	},
}

The second Entity._children loop: calculate max_length for each resizable component/children (i.e. highlight and symlink components)

-- Usable/Free space for resizable components (tab current width minus total used space of unresizable components)
local total_length_unresizable = entity_line_number_char_length + linemode_char_length + icon, prefix, found length, etc
-- 
-- (this is because those two component aren't entity components, so we have to minus their `character length/count` manually. This is why I don't know how to port it to Yazi's codebase)

local usable_space = current_tab_window_w - total_length_unresizable
local percent_per_length_size = 100 / total_length_resizable

-- Calculate max_length for each resizable component/children
for c_idx, c in ipairs(entity_self._children) do
   if c.resizable then
       entity_self._children[c_idx].max_length = math.floor(
   	    percent_per_length_size * c.length * usable_space / 100
       ) - count_resizable_component
   end
end

The last thing: replace render function of each resizable entity component (highlight, symlink)

I modified both entity.highlights and entity.symlink instead of the global Entity:highlight and Entity:symlink.
They use shorten func to truncate the filename, link_to before rendering, which takes 3 arguments (max_width, the filename/link_to/etc, the extension/tail).

At the end, run last loop again to render entities. And return it to Current.render.

@ssqzr
Copy link

ssqzr commented Nov 12, 2024

Features request:

  • add --chooser-dir cli option for choose a directory
  • add --show-only-dirs cli option for show only directory when choose directory
  • add --chooser-file cli option for choose one file
  • add --chooser-file cli option for choose multiple files

all features for org.freedesktop.impl.portal.FileChooser

@boydaihungst
Copy link
Contributor

boydaihungst commented Nov 12, 2024 •
edited
Loading

Features request:

* add `--chooser-dir`  cli option for choose a directory

* add `--show-only-dirs` cli option for show only directory when choose directory

* add `--chooser-file` cli option for choose one file

* add `--chooser-file` cli option for choose multiple files

all features for org.freedesktop.impl.portal.FileChooser

https://github.com/boydaihungst/xdg-desktop-portal-termfilechooser/blob/a0b20c06e3d45cf57218c03fce1111671a617312/contrib/yazi-wrapper.sh#L79

Most of them are implemented. "show-only-dirs" isn't.

@ssqzr
Copy link

ssqzr commented Nov 13, 2024

Features request:

* add `--chooser-dir`  cli option for choose a directory

* add `--show-only-dirs` cli option for show only directory when choose directory

* add `--chooser-file` cli option for choose one file

* add `--chooser-file` cli option for choose multiple files

all features for org.freedesktop.impl.portal.FileChooser

https://github.com/boydaihungst/xdg-desktop-portal-termfilechooser/blob/a0b20c06e3d45cf57218c03fce1111671a617312/contrib/yazi-wrapper.sh#L79

Most of them are implemented. "show-only-dirs" isn't.

Yes, and choose only on item isn't.

@DALLI-KAKTUS
Copy link

Feature Request:

  • docs website as man page.

@boydaihungst
Copy link
Contributor

Feature Request:

  • Add an option to limit the maximum file size to run the previewer, preloaders, and spotters.

For example, { mime = "text/*", file_size_under = "10MB", run = "code" } → Only run code previewer/preloader if the file size is smaller than 10 MB. Helpful when working on a remote storage.

@voronind-com
Copy link

Can we have a separate shell completion issue for easier tracking?

@sxyazi sxyazi mentioned this issue Nov 30, 2024
Closed
3 tasks
@SL-RU
Copy link

SL-RU commented Nov 30, 2024

Maybe add to features list in next release or in the roadmap Virtual File System for archive, iso or remote ssh/ftp/s3 system mounting without real mount point in system?

@sxyazi sxyazi mentioned this issue Dec 4, 2024
Closed
3 tasks
@boydaihungst
Copy link
Contributor

Feature Request:
Adding tab_close --current to close current active tab.

After this PR #1826, tab_close and tab_close 0 won't close current active tab anymore.

@sxyazi
Copy link
Owner Author

sxyazi commented Dec 7, 2024

@boydaihungst

tab_close or tab_close 0 means to close the tab at the first position (starting from 0). If it previously worked to close the current tab, that's probably a bug.

Closing the current tab has always been done with the close command:

yazi/yazi-config/preset/keymap.toml

Line 12 in 7c445ce

{ on = "<C-c>", run = "close", desc = "Close the current tab, or quit if it is last tab" },

https://yazi-rs.github.io/docs/quick-start#multi-tab

@boydaihungst
Copy link
Contributor

@sxyazi i didn't notice it. Thanks you. 🙏

@c02y
Copy link

c02y commented Dec 9, 2024 •
edited
Loading

Maybe add to features list in next release or in the roadmap Virtual File System for archive, iso or remote ssh/ftp/s3 system mounting without real mount point in system?

ftp is the only reason I still keep a GUI file manager installed, although I don't use it that much, but it is nice if yazi supports remote file management through protocols like FTP.

For reference: #611

@ingenarel
Copy link

make the plugins directory a separate directory from config. would make sharing configs more easy and not clutter up the config directory.

@magdesign magdesign mentioned this issue Dec 22, 2024
Closed
3 tasks
@TobisLee
Copy link
Contributor

Hey, @sxyazi , in #694 issue, DirkFi give a way to fix it. But seems like he doesn't file a PR, and you close the issue. I try to implement it. But when I import yazi-config in yazi-shared, the cargo shows the "error: cyclic package dependency".

May I ask that is his idea right or you have a better way to fix this issue?

@sxyazi
Copy link
Owner Author

sxyazi commented Dec 23, 2024

@TobisLee Please raise a PR with the code that can't be built, and we can explore how to resolve it and the specific implementation details there.

Really appreciate you grabbing this work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests