Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use normalize_z? #54

Open
Anqw opened this issue Aug 17, 2022 · 2 comments
Open

Why use normalize_z? #54

Anqw opened this issue Aug 17, 2022 · 2 comments

Comments

@Anqw
Copy link

Anqw commented Aug 17, 2022

Thanks for your wonderful work, I have some doubts about coordinate conversion. Why only rotate without translation when transforming to a reference coordinate system?
in src/model/models.py
image
image

@taehoon-yoon
Copy link

Me either. Don't know why didn't use translation.

@hcw0098
Copy link

hcw0098 commented Oct 19, 2022

I trained the model using the repo, and find adding translation gives higher psnr(19.28) on DTU 3 views setting, higher than normalize z setting (psnr 18.72), don't know why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants