Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There may be one 'bug' in models.py ? #68

Open
smallreed opened this issue Aug 15, 2023 · 0 comments
Open

There may be one 'bug' in models.py ? #68

smallreed opened this issue Aug 15, 2023 · 0 comments

Comments

@smallreed
Copy link

In the file 'models.py’, the following code seems wrong:

Grab encoder's latent code.

uv = -xyz[:, :, :2] / xyz[:, :, 2:] # (SB, B, 2)

The 'correct' one should be:

Grab encoder's latent code.

#uv = -xyz[:, :, :2] / xyz[:, :, 2:] # (SB, B, 2)
h = xyz[:, :, 1:2] / xyz[:, :, 2:]
w = -xyz[:, :, 0:1] / xyz[:, :, 2:]
uv = torch.cat([h,w], dim = -1)

Looking forward to receiving a response from the author as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant