Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewDirs vs Direction in the named tuple Rays #21

Open
saunair opened this issue Mar 3, 2022 · 0 comments
Open

ViewDirs vs Direction in the named tuple Rays #21

saunair opened this issue Mar 3, 2022 · 0 comments

Comments

@saunair
Copy link

saunair commented Mar 3, 2022

Why not just have the direction field with the origin, and remove the viewdirs field in Rays?
The direction field should always contain the normalized direction (unit vector) anyway. If the un-normalized direction doesn't serve a specific purpose, these twin fields will cause confusion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saunair