Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple selection #2

Open
mjuchli opened this issue Dec 8, 2013 · 5 comments
Open

Multiple selection #2

mjuchli opened this issue Dec 8, 2013 · 5 comments

Comments

@mjuchli
Copy link

mjuchli commented Dec 8, 2013

Nice plugin!
Is there a chance you provide multiple selection support?

@sylvain-hamel
Copy link
Owner

Hi @backender, thanks. I don't think I'll have time to work on this feature. If you decide to do it, please send me a pull request.

@liquidboy
Copy link

I have a Multiple selection AND OptGroup implementation of this .. I needed it for my work project , when I get a chance tonight Ill fork and upload my version ... Thanks for your contribution Sylvain-Hamel :)

@sylvain-hamel
Copy link
Owner

Hi, ok thank you too. Can you make sure you don't loose the selected values when $("#select1").trigger('item-added'); is triggered as to be compatible with #3

@liquidboy
Copy link

Hi, its hard for me to suggest a PULL because I've made quite a bit of changes and wasn't sure if you'd want it in your master... its sitting in my branch at the moment , I tried to honour your code and sample so it doesn't break single select ...

For my purposes I added the following

  • honour existing Single-Select logic
  • support Select Multiple
  • support Select Disabled
  • support Select OptGroup
  • support Select width/height syncing with UL width/height
  • support Select Size overriding UL width/height when applicable (business logic)

The experiments.html shows all the cases I cover in my changes ...

https://github.com/liquidboy/safarimobile-multiline-select

@sylvain-hamel
Copy link
Owner

Hi, ok it'd be nice to merge back here. I just had a very quick look at your changes and we should be able to merge them. I'll have a closer look as soon as I can and I'll let you know.

Now that this is getting bigger, I'll add unit tests too. I don't even know how I wrote that without some unit tests; shame on me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants