Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish workflow naming #45

Closed
dbu opened this issue May 24, 2013 · 3 comments
Closed

publish workflow naming #45

dbu opened this issue May 24, 2013 · 3 comments
Milestone

Comments

@dbu
Copy link
Member

dbu commented May 24, 2013

i wonder about the publish workflow naming and concept. should we have a concept that PublishWorkflowCheckerInterface can be chained, having isPublished return true|false|null ?

also i wonder if PublishWorkflowChecker should be called TimebasedPublishChecker or something, and the PublishWorkflowInterface TimebasedWorkflowInterface? we could already now split out the ispublished flag from the timebased and start to have a chain. then it would be easy to add other workflow checkers to the chain, for example based on a user role or whatever people come up with.

@dantleech
Copy link
Member

Actually, I wonder also if this shouldn't be broken down into 2 interfaces: PublishableInterface and PublishTimePeriodInterface. Or maybe even, having just looked at Typo3, VisibileInterface and PublishDatesInterface.

@dbu
Copy link
Member Author

dbu commented May 26, 2013

yes, i think that would make sense. and then we would start having a PublishCheckerChain running PublishableChecker and PublishDatesChecker that get active if the model implements PublishableInterface resp PublishDatesInterface. hm, i just dropped workflow here, but i think it does make sense to drop it as anyway none of this helps with workflows, only with the binary visibility decision.

@dbu
Copy link
Member Author

dbu commented Jul 15, 2013

fixed in #59

@dbu dbu closed this as completed Jul 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants