Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve unexpected dependency from CoreBundle to SonataAdminBundle #60

Closed
aalexandrov opened this issue Jun 23, 2013 · 2 comments
Closed

Comments

@aalexandrov
Copy link

Due to the recent addition of the PublishWorkflowExtension.php, the CoreBundle now depends on some classes from the SonataAdminBundle included explicitly in the extension.

This dependency should be reflected under "require" in composer.json, or the PublishWorkflowExtension.php execution in the post-install composer.phar hooks should be made optional by default.

I managed to fix this by adding "sonata-project/doctrine-phpcr-admin-bundle": "1.0.*" to my project's composer.json, but I guess this is not an ideal solution.

@dbu
Copy link
Member

dbu commented Jun 23, 2013

we are currently refactoring the publish workflow in #59 - including the service definition, so we could do things there. i was assuming that just having the service defined should not lead to a problem as when there is no sonata, it would never be requested. when and how exactly do you see the issue?

the intention is to keep sonata admin optional.

@dbu
Copy link
Member

dbu commented Jul 15, 2013

i just removed the sonata-project/admin-bundle and sonata-project/doctrine-phpcr-admin-bundle in the cmf sandbox and removed all sonata related configuration. then i just needed a dummy route for the "Admin" entry in the demo menu and could load the home page of the sandbox.

so i don't see where or how we would have the dependency. can you tell me how to produce the exception?

@dbu dbu closed this as completed Jul 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants