You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
As discussed in https://github.com/symfony-cmf/SeoBundle/pull/263/files#r40062307 this method has a strange name. what we do is add seo information. the method should be called something like updateMetadata... this would be an interface change so we can only do it for 2.0
The text was updated successfully, but these errors were encountered:
I probably should have put this comment here but I think use of the word Document is overly specific to PHPCR and this method can work for anything that implements the SeoMetadata interface. Other suggestions:
updateSeoMetadataFrom($object) // this one gets my vote
updateSeoMetadataFromObject($object)
updateSeoMetadataFromContent($content) // content doesnt seem like the right name in this case
We could use SeoInformation instead of SeoMetadata in any of these names
updateSeoMetadataFrom($object) // this one gets my vote
if we ever update it from something else, this would be odd. like
updateSeoMetadataFromEntityId or something. then again we can just go
with ...From() and all other cases have an explicit name. this is the
default case.
As discussed in https://github.com/symfony-cmf/SeoBundle/pull/263/files#r40062307 this method has a strange name. what we do is add seo information. the method should be called something like
updateMetadata
... this would be an interface change so we can only do it for 2.0The text was updated successfully, but these errors were encountered: