Fix form for orm #277
Fix form for orm #277
Conversation
|
👍 (maybe add a test to test if everything works correctly for both PHPCR + ORM?) |
|
There is a broken WebTest. Looks like an other Field is missing now. |
| @@ -91,6 +91,7 @@ public function configureOptions(OptionsResolver $resolver) | |||
| 'data_class' => $this->dataClass, | |||
| 'translation_domain' => 'CmfSeoBundle', | |||
| 'required' => false, | |||
| 'by_reference' => false, | |||
There was a problem hiding this comment.
adding this makes the test fail. i checked in the sandbox, and with PHPCR this leads to "A detached document was found through a child relationship during cascading a persist operation: Symfony\Cmf\Bundle\SeoBundle\Doctrine\Phpcr\SeoMetadata@0000000073c1c05d0000000089dcaddb"
i will make the form type aware of whether we use ORM or not.
| @@ -78,6 +78,11 @@ public function load(array $configs, ContainerBuilder $container) | |||
| $sonataBundles[] = 'SonataDoctrineORMBundle'; | |||
| } | |||
|
|
|||
| $container->setParameter($this->getAlias().'.form_mode_orm', | |||
There was a problem hiding this comment.
we can't use the backend_type_* parameters because they must only be set if true (the doctrine compiler pass only checks if the parameter exists, not the value of the parameter). and anyways, we want this logic in case somebody enabled both backends.
|
okay, getting there. pushed some fixes for the --dev build. |
|
and its green! review anybody? |
|
Looks good to me. Nice hack with the orm parameter. |
|
@dbu i would like to give you the honor of tagging and releasing :-) (ill at home with ill children next to me) |
fix #275