Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Init version - what's the plan? #61

Closed
ElectricMaxxx opened this issue Mar 24, 2014 · 12 comments
Closed

Init version - what's the plan? #61

ElectricMaxxx opened this issue Mar 24, 2014 · 12 comments

Comments

@ElectricMaxxx
Copy link
Member

As we try to get this bundle stable until 03-03-2014, we need a plan how to fix the issues. All issues that are needed to be fixed are tagged with "init version". There should be a kind of order closing that issues:

Out of Order - Admin fixes

There are some issues that are out of the order - the admin stuff.
Here the Extension should be tested #31, there is an extra issue to check if the translation domain works #16 and one feature for documents that implements the RouteRefferrersInterface #2. These issues should be bundled into #53.
As that issues doesn't touch the SeoPresentation they can be handled by the way. Even the strategy for handling routes, that are referenced by uuid is working: SeoRouteExtractor should be able to extract the uuid of a route node, which is converted to a absolute url later.

Stuff that depends on the SeoPresentation

At first the #60 (issue #55) has to be merged. Than we should be able to do the following issues fast: #58 and #54 based on the changes in #60. Maybe @dbu can do #58 in his PR? That shouldn't change any behavior or tests.
When these things are done we can do the last big break: #59 This issue touches configuration, SeoPresentation and tests. But will reduce the responsibility of the SeoPresentation a lot.
When this last break is done, the #34 and documentation can be done and finished.

I have got Monday and Wednesday where i have my second job in the evening, where i will be home at 10 pm, but will do the hard stuff on Tuesday/Thursday to have the light stuff (docs and config prepending) for Friday.

@wouterj
Copy link
Member

wouterj commented Mar 24, 2014

You can better use milestones for this instead of labels

@ElectricMaxxx
Copy link
Member Author

What is the difference? Milestones Sound like tags.

@wouterj
Copy link
Member

wouterj commented Mar 24, 2014

  • It keeps track of the planned release date
  • It keeps track of the progress
  • It is created specifically for managing what has to be done before a release
  • many more good reasons

@dbu
Copy link
Member

dbu commented Mar 24, 2014

sorry, my fault for proposing the tags. wouter is right that its more
visible.
the only thing i don't like is that on the issue list you don't see the
milestones an issue is in - you can only filter by milestone but then
you don't see the other issues anymore at all.

@ElectricMaxxx ElectricMaxxx added this to the init version milestone Mar 24, 2014
@ElectricMaxxx
Copy link
Member Author

It looks good atm.

@dbu
Copy link
Member

dbu commented Mar 26, 2014

yep. i started to prepare for the transfer. i created the SeoBundle
group and gave you admin on that.

note that we follow the symfony core example of not following the naming
convention for github repos for bundles, so the repository should be
SeoBundle, not CmfSeoBundle - can you start the process to transfer the
repo from your organization to symfony-cmf/SeoBundle? i think you should
be able to do that now that you are in team SeoBundle:
https://help.github.com/articles/how-to-transfer-a-repository#transferring-between-organization-accounts

can you please try?

@wouterj
Copy link
Member

wouterj commented Mar 26, 2014

Symfony core has changed it's naming conventions to use the composer packages, so seo-bundle. See http://github.com/symfony/expression-language as an example.

@dbu
Copy link
Member

dbu commented Mar 26, 2014

hm. makes sense.
but we should be consistent so i think SeoBundle would make more sense
right now. and does renaming them not create a big confusion everywhere?
or is that harmless and we could just do it for all the other bundles?

@wouterj
Copy link
Member

wouterj commented Mar 26, 2014

No, I think we should just stick to our own standard. Having such an extreme inconsistency naming conventions in Symfony is really one of the -1 points of sf imo.

GitHub would redirect named packages, but GitHub API can't redirect them. So it'll break all projects using a composer.lock file without updating them. After running composer update, everything should be OK. But while, I wouldn't advise doing so

@dbu
Copy link
Member

dbu commented Mar 26, 2014

okay. then SeoBundle it is. @ElectricMaxxx can you try to move the repo
and tell me if it works out? (i think the option is somewhere in the
"Danger Zone" of the repository settings)

@ElectricMaxxx
Copy link
Member Author

I will try it in the evening. I am on my second job atm, there is no real PC.

@ElectricMaxxx
Copy link
Member Author

So everything is done. Thanks to @wouterj on the last but more important issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants