Why custom delegates?

[michael-e]

Forgive me if this question is stupid or has been asked before — I have never used the reflection field actively, so I have not followed all discussions.

I was wondering why the XMl Importer has custom delegates XMLImporterEntryPostCreate and XMLImporterEntryPostEdit. The custom delegates must be called by other extensions, e.g. the Reflection Field.

Why not use Symphony's delegates EntryPostCreate and EntryPostEdit instead? Is there any special reason for this?

[nitriques]

I seriously to do know why. I do not think it's bad since one may wants to do special things only when importing data... But the "core" delegates should be fired too, IMHO.

[nitriques]

I would ping @andrewminton since he's the one who submitted #25

[andrewminton]

My commit was to be able to handle post event creation triggers.. i.e. send an email to myself once an import had completed.. reporting how many imports were successful/had errors. If this could be done with the core alone.. then there is no need for them. It was a proof of concept without enough in depth knowledge of the core so ignore/revert/do as you please I have no issue with that commit being rejected.

[nitriques]

So they have a valid reason to exist... but I think we should call the core one as well. Thanks Andrew!

[andrewminton]

No worries. I'm not as knowledgable about the core so felt like introducing a delegate in the importer was right and was fit for purpose. But I guess the reflection field case is a little different. If post creation you then need to trigger an edit of that created field to reflect the value... is the core better suited at handling that.. rather than introducing a new deldegate... is that what you mean @michael-e ?

[nitriques]

Introducing a new delegate was the right thing to do: You would not want to send an email on each and every EntryPostEdit ... But not calling the core one is a missing feature IMHO.

[michael-e]

Agreed. Will create a new issue for the missing core delegates.

[nitriques]

Thanks Micheal

[michael-e]

I noticed that the delegates I was talking about were not the ones introduced by @andrewminton. I was talking about XMLImporterEntryPostCreate and XMLImporterEntryPostEdit; those are much older, I think. I will add a short comment to #48.