Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NASOQ contains LGPL code #18

Open
essexe opened this issue Mar 18, 2022 · 1 comment
Open

NASOQ contains LGPL code #18

essexe opened this issue Mar 18, 2022 · 1 comment

Comments

@essexe
Copy link

essexe commented Mar 18, 2022

NASOQ says it is MIT licensed, but comments in mgmres.cpp say that code is LGPL. I don't think re-licensing someone else's LGPL code as MIT is valid/legal.

@cheshmi
Copy link
Collaborator

cheshmi commented Mar 18, 2022

Thanks for raising the issue. NASOQ uses LDL-preconditioned GMRES which is different than the LGPL version GMRES (which is ILU-preconditioned). This function is what NASOQ uses that has nothing with those comments. The comments are not applicable to the code mostly as they have a different prototype. I will clean up the code to address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants