Skip to content
This repository has been archived by the owner on Nov 27, 2017. It is now read-only.

Add branding config to config.json #89

Open
gashcrumb opened this issue Sep 21, 2017 · 6 comments
Open

Add branding config to config.json #89

gashcrumb opened this issue Sep 21, 2017 · 6 comments

Comments

@gashcrumb
Copy link
Contributor

gashcrumb commented Sep 21, 2017

For syndesis-ui

@gashcrumb gashcrumb self-assigned this Sep 21, 2017
@gashcrumb
Copy link
Contributor Author

gashcrumb commented Sep 21, 2017

This is the additional data that's needed in config.json:

        "branding": {
          "logoWhiteBg": "assets/images/syndesis-logo-svg-white.svg",
          "logoDarkBg": "assets/images/syndesis-logo-svg-white.svg",
          "iconWhiteBg": "assets/images/glasses_logo_square.png",
          "iconDarkBg": "assets/images/glasses_logo_square.png",
          "appName": "Syndesis",
          "favicon32": "/favicon-32x32.png",
          "favicon16": "/favicon-16x16.png",
          "touchIcon": "/apple-touch-icon.png"
        },

@gashcrumb gashcrumb removed their assignment Sep 21, 2017
@gashcrumb
Copy link
Contributor Author

@rhuss of course, I'm on Windows here, which can't run run.sh properly :-)

@gashcrumb
Copy link
Contributor Author

gashcrumb commented Sep 21, 2017

Settings for product:

  "branding": {
    "logoWhiteBg": "",
    "logoDarkBg": "",
    "iconWhiteBg": "assets/images/FuseIgniteLogo_Black.svg",
    "iconDarkBg": "assets/images/FuseIgniteLogo_White.svg",
    "appName": "Fuse Ignite",
    "favicon32": "/favicon-32x32.png",
    "favicon16": "/favicon-16x16.png",
    "touchIcon": "/apple-touch-icon.png"
  },,

@rhuss
Copy link
Contributor

rhuss commented Sep 22, 2017

Cool, thanks ! Going to update the templates accordingly.

@rhuss
Copy link
Contributor

rhuss commented Sep 22, 2017

See #90 for the template PR.

@gashcrumb
Copy link
Contributor Author

Awesome, thanks! I got updated product SVGs for the logo, updated the example config above just so we don't forget 'em. I left the previous product logo in the repo too just to be on the safe side, it's effectively the same really.

rhuss added a commit to rhuss/openshift-templates that referenced this issue Sep 23, 2017
Also, combined the selection of product images with the selection of product configuration in the template generation.

Refers to syndesisio#89
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants