Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect file version check for text files #115

Open
firsinanton opened this issue Feb 2, 2018 · 1 comment
Open

Incorrect file version check for text files #115

firsinanton opened this issue Feb 2, 2018 · 1 comment

Comments

@firsinanton
Copy link

FeedBuilder generates version"0.0.0.0" for text files (such as .config files).
If we generates with CompareVersion=True, it includes for that files the following condition:

While checking for update it checks this version with the version of text file, and version becomes null:
(FileVersionCondition.cs: 37)

var versionInfo = FileVersionInfo.GetVersionInfo(localPath);
if (versionInfo.FileVersion == null) return true; // perform the update if no version info is found

And in this case NAppUpdate thies to update these files every time, even they are binary equal to each other.

@firsinanton
Copy link
Author

Either FeedBuiler should check if FileVersion is null, and do not generate FileVersionCondition for such files; or you should change FileVersionCondition behavior in such situations; or FeedBuilder should have smarter settings capabilities, for example, possibility to set different conditions for each files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant