Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: update nobleSecp256k1Wrapper.js #813

Closed
landabaso opened this issue Jan 10, 2023 · 4 comments · Fixed by #1522
Closed

[Bug]: update nobleSecp256k1Wrapper.js #813

landabaso opened this issue Jan 10, 2023 · 4 comments · Fixed by #1522
Assignees
Labels
bug Something isn't working low priority This doesn't need to happen right away

Comments

@landabaso
Copy link

landabaso commented Jan 10, 2023

Describe the bug

Hi there.

I noticed that you are currently using an old version of the code that I wrote for farvault. The specific file in question is nobleSecp256k1Wrapper.js

I have since found and fixed some minor bugs in the code, and have refactored it into a new package called https://github.com/bitcoinerlab/secp256k1. This new package passes all tests against BitcoinJS's tiny-secp256k1 test-suite.

I would suggest either updating your nobleSecp256k1Wrapper.js file with the new code from the Github repository, or even better using the new npm package I've created and will maintain. Let me know if you need any help or if there's anything else I can do to assist you.

Reproduce

Nothing to reproduce

Screenshots / Recording

No response

Operating system

Anything related to RN

Bitkit version

No response

Log output

No response

@landabaso landabaso added bug Something isn't working triage This issue needs to be looked over by the team labels Jan 10, 2023
@coreyphillips
Copy link
Collaborator

Thanks for creating this issue, @landabaso. Looking into this now.

@landabaso
Copy link
Author

Great @coreyphillips . Take a look to the comment linked below for more context and let me know if I can help.

bitcoinjs/bitcoinjs-lib#1781 (comment)

@JeanlChristophe JeanlChristophe added low priority This doesn't need to happen right away and removed triage This issue needs to be looked over by the team labels Mar 2, 2023
@junderw
Copy link

junderw commented Jul 22, 2023

@landabaso has since made @bitcoinerlab/secp256k1 and I just released a new asmjs based package that will be released in lock step with WASM.

bitcoinjs/bitcoinjs-lib#1781 (comment)

@coreyphillips
Copy link
Collaborator

Thanks @junderw and @landabaso!

@bitcoinerlab/secp256k1 was added as of this PR.

Will look into replacing the old nobleSecp256k1Wrapper.js in the nodejs thread with @bitcoin-js/tiny-secp256k1-asmjs after some testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority This doesn't need to happen right away
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants