Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flipAxisAndUpdatePCP() does not update dimensions.tickvalues #327

Open
sephali opened this issue Sep 15, 2016 · 1 comment
Open

flipAxisAndUpdatePCP() does not update dimensions.tickvalues #327

sephali opened this issue Sep 15, 2016 · 1 comment

Comments

@sephali
Copy link

sephali commented Sep 15, 2016

If dimension tickvalues are explicitly set by external code . User defined tick values goes off when double clicked on Axis (Flip Axis) .

In flipAxisAndUpdatePCP(dimension) , below line of code

d3.select(this.parentElement)
.transition()
.duration(.animationTime)
.call(axis.scale(.dimensions[dimension].yscale));

should be replaced with

d3.select(this.parentElement)
  .transition()
  .duration(__.animationTime).call( pc.applyAxisConfig(axis, __.dimensions[dimension]));

This can set all tick details set externally.
@timelyportfolio
Copy link
Contributor

ref #325 and #265

abuzreq added a commit to abuzreq/parcoords-es that referenced this issue May 12, 2021
@abuzreq
Update flipAxisAndUpdatePCP.js
1cce8f9 
Applying fix by syntagmatic/parallel-coordinates#327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timelyportfolio @sephali