Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls? #256

Open
brodycj opened this issue Aug 29, 2018 · 1 comment
Open

Coveralls? #256

brodycj opened this issue Aug 29, 2018 · 1 comment

Comments

@brodycj
Copy link
Contributor

brodycj commented Aug 29, 2018

I noticed that while coveralls is used in Travis CI it would produce no extra output on a passing build (see GH-251 for passing "Node.js" build). I can think of a couple possible solutions:

  • completely remove coveralls
  • update coveralls to resolve npm audit issues then configure a reporter or connect to coveralls.io

P.S. What should we do about travis-cov devDep? Can we remove it? (travis-cov is now removed)

This was referenced Aug 30, 2018
@dmikey
Copy link
Collaborator

dmikey commented Aug 30, 2018

So I think we want to try to solve the conflicts, looking back through the project, it indeed was intended to produce security coverage scans for SonarCloud. I'll put this on a list of things to look at, perhaps it is indeed extraneous. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants