Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cluster-scanner): Add dynamic envs to values #1358

Merged
merged 4 commits into from
Sep 15, 2023
Merged

feat(cluster-scanner): Add dynamic envs to values #1358

merged 4 commits into from
Sep 15, 2023

Conversation

FedericoFeresini
Copy link
Collaborator

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Sep 13, 2023
ProvoK
ProvoK reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@ProvoK ProvoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments, thanks for working on this @FedericoFeresini

charts/cluster-scanner/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/cluster-scanner/values.yaml Show resolved Hide resolved
@github-actions github-actions bot removed the no-tests Chart templates modified without test changes label Sep 15, 2023
ProvoK
ProvoK approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@ProvoK ProvoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @FedericoFeresini !

@FedericoFeresini FedericoFeresini merged commit b4b4e29 into master Sep 15, 2023
5 checks passed
@FedericoFeresini FedericoFeresini deleted the ff/env/clusterScanner branch September 15, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProvoK ProvoK ProvoK approved these changes

@michele-mangili michele-mangili michele-mangili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FedericoFeresini @ProvoK @michele-mangili