From 742680223a5292f034bf97bc33325bd9feb1e5e1 Mon Sep 17 00:00:00 2001 From: Alvaro Iradier Date: Wed, 29 Nov 2023 19:42:45 +0100 Subject: [PATCH 1/3] feat(node-analyzer): In-USE (EVE) enabled by default --- charts/node-analyzer/Chart.yaml | 2 +- charts/node-analyzer/README.md | 2 +- charts/node-analyzer/templates/daemonset-node-analyzer.yaml | 2 -- .../templates/runtimeScanner/runtime-scanner-configmap.yaml | 2 -- charts/node-analyzer/tests/conditional_flag_test.yaml | 4 ++-- charts/node-analyzer/values.yaml | 2 +- 6 files changed, 5 insertions(+), 9 deletions(-) diff --git a/charts/node-analyzer/Chart.yaml b/charts/node-analyzer/Chart.yaml index c43010a15..1420f668f 100644 --- a/charts/node-analyzer/Chart.yaml +++ b/charts/node-analyzer/Chart.yaml @@ -3,7 +3,7 @@ name: node-analyzer description: Sysdig Node Analyzer # currently matching Sysdig's appVersion 1.14.34 -version: 1.18.8 +version: 1.18.9 appVersion: 12.9.0 keywords: - monitoring diff --git a/charts/node-analyzer/README.md b/charts/node-analyzer/README.md index 79cbaad08..aa532dc8e 100644 --- a/charts/node-analyzer/README.md +++ b/charts/node-analyzer/README.md @@ -228,7 +228,7 @@ The following table lists the configurable parameters of the Sysdig Node Analyze | `nodeAnalyzer.runtimeScanner.resources.limits.ephemeral-storage` | Specifies the Runtime Scanner Storage limit per node. | `4Gi` | | `nodeAnalyzer.runtimeScanner.sslVerifyCertificate` | Set to `false` to allow insecure connections to the Sysdig backend, such as an On-Prem deployment. | | | `nodeAnalyzer.runtimeScanner.env` | Specifies the extra environment variables that will be passed onto pods. | `{}` | -| `nodeAnalyzer.runtimeScanner.settings.eveEnabled` | Enables Sysdig Eve | `false` | +| `nodeAnalyzer.runtimeScanner.settings.eveEnabled` | Enables Sysdig Eve | `true` | | `nodeAnalyzer.runtimeScanner.eveConnector.image.repository` | Specifies the image repository to pull the Eve Connector from. | `sysdig/eveclient-api` | | `nodeAnalyzer.runtimeScanner.eveConnector.image.tag` | Specifies the image tag for the Eve Connector to be pulled. | `1.1.0` | | `nodeAnalyzer.runtimeScanner.eveConnector.deploy` | Enables Sysdig Eve Connector for third-party integrations. | `false` | diff --git a/charts/node-analyzer/templates/daemonset-node-analyzer.yaml b/charts/node-analyzer/templates/daemonset-node-analyzer.yaml index 0f6ac844e..e64f57a2a 100644 --- a/charts/node-analyzer/templates/daemonset-node-analyzer.yaml +++ b/charts/node-analyzer/templates/daemonset-node-analyzer.yaml @@ -719,8 +719,6 @@ spec: name: {{ .Release.Name }}-runtime-scanner key: eve_enabled optional: true - {{- end }} - {{- if .Values.nodeAnalyzer.runtimeScanner.eveConnector.deploy }} - name: EVE_INTEGRATION_ENABLED valueFrom: configMapKeyRef: diff --git a/charts/node-analyzer/templates/runtimeScanner/runtime-scanner-configmap.yaml b/charts/node-analyzer/templates/runtimeScanner/runtime-scanner-configmap.yaml index 4aa125e58..8fc75419b 100644 --- a/charts/node-analyzer/templates/runtimeScanner/runtime-scanner-configmap.yaml +++ b/charts/node-analyzer/templates/runtimeScanner/runtime-scanner-configmap.yaml @@ -23,8 +23,6 @@ data: {{- end -}} {{- if .Values.nodeAnalyzer.runtimeScanner.settings.eveEnabled }} eve_enabled: "true" - {{- end -}} - {{- if hasKey .Values.nodeAnalyzer.runtimeScanner "eveConnector" }} eve_integration_enabled: "true" {{- end -}} {{- if hasKey .Values.nodeAnalyzer.runtimeScanner "settings" }} diff --git a/charts/node-analyzer/tests/conditional_flag_test.yaml b/charts/node-analyzer/tests/conditional_flag_test.yaml index 83a0c8edd..ac868d7df 100644 --- a/charts/node-analyzer/tests/conditional_flag_test.yaml +++ b/charts/node-analyzer/tests/conditional_flag_test.yaml @@ -195,7 +195,7 @@ tests: count: 1 any: true - - it: Check nodeAnalyzer runtimeScanner eveConnector deploy set to false + - it: Check nodeAnalyzer runtimeScanner EVE_INTEGRATION_ENABLED is true even if eveConnector deploy set to false set: nodeAnalyzer: runtimeScanner: @@ -204,7 +204,7 @@ tests: deploy: false clusterName: test-k8s asserts: - - notContains: + - contains: path: spec.template.spec.containers[3].env content: name: EVE_INTEGRATION_ENABLED diff --git a/charts/node-analyzer/values.yaml b/charts/node-analyzer/values.yaml index 641d8cf1a..d1a6b4a1c 100644 --- a/charts/node-analyzer/values.yaml +++ b/charts/node-analyzer/values.yaml @@ -337,7 +337,7 @@ nodeAnalyzer: env: {} settings: - eveEnabled: false + eveEnabled: true # Threshold for which images will be skipped in the analysis. # Size is in bytes, default is not set (don't skip) # maxImageSizeAllowed: "" From 589b877a02ec038a8d705730299e7b97454feb25 Mon Sep 17 00:00:00 2001 From: Alvaro Iradier Date: Tue, 12 Dec 2023 19:23:49 +0100 Subject: [PATCH 2/3] Bumping minor version --- charts/node-analyzer/Chart.yaml | 2 +- charts/sysdig-deploy/Chart.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/node-analyzer/Chart.yaml b/charts/node-analyzer/Chart.yaml index 602a1e1ce..deb5d676a 100644 --- a/charts/node-analyzer/Chart.yaml +++ b/charts/node-analyzer/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: node-analyzer description: Sysdig Node Analyzer # currently matching Sysdig's appVersion 1.14.34 -version: 1.19.3 +version: 1.20.0 appVersion: 12.9.0 keywords: - monitoring diff --git a/charts/sysdig-deploy/Chart.yaml b/charts/sysdig-deploy/Chart.yaml index 3e31c4ee1..74f2c01ec 100644 --- a/charts/sysdig-deploy/Chart.yaml +++ b/charts/sysdig-deploy/Chart.yaml @@ -36,7 +36,7 @@ dependencies: - name: node-analyzer # repository: https://charts.sysdig.com repository: file://../node-analyzer - version: ~1.19.2 + version: ~1.20.0 alias: nodeAnalyzer condition: nodeAnalyzer.enabled - name: cluster-scanner From 5c01b9660e181927d2bd64985803a7e98aa9e685 Mon Sep 17 00:00:00 2001 From: Alvaro Iradier Date: Tue, 12 Dec 2023 19:28:42 +0100 Subject: [PATCH 3/3] Bump sysdig-deploy version --- charts/sysdig-deploy/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/sysdig-deploy/Chart.yaml b/charts/sysdig-deploy/Chart.yaml index 74f2c01ec..70b7ac505 100644 --- a/charts/sysdig-deploy/Chart.yaml +++ b/charts/sysdig-deploy/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: sysdig-deploy description: A chart with various Sysdig components for Kubernetes type: application -version: 1.33.3 +version: 1.34.0 maintainers: - name: AlbertoBarba email: alberto.barba@sysdig.com