Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-profile permissions not available #4

Open
jensschuppe opened this issue Nov 11, 2020 · 2 comments
Open

Per-profile permissions not available #4

jensschuppe opened this issue Nov 11, 2020 · 2 comments
Assignees
@jensschuppe
Labels
enhancement New feature or request status:fixed The issue has been resolved (usually by committing/merging code)
Milestone
1.0

Comments

@jensschuppe
Copy link
Collaborator

jensschuppe commented Nov 11, 2020 •
edited
Loading

There should be permissions for all three forms per profile. This, however, does not work because the API always returns the default profile when no profile name is submitted.

The NewsletterProfile.get API should return multiple profiles. There should be a NewsletterProfile.getsingle API action for querying only one profile or the default profile if no name is provided.

This module should then be adapted to use the correct API action.

See systopia/de.systopia.newsletter#10
@jensschuppe jensschuppe self-assigned this Nov 11, 2020
@jensschuppe jensschuppe added the enhancement New feature or request label Nov 11, 2020
@jensschuppe jensschuppe modified the milestones: 1.0, 7.x-1.0 Nov 11, 2020
@jensschuppe
Copy link
Collaborator Author

This applies to both D7 and D8/9.

jensschuppe added a commit that referenced this issue Nov 11, 2020
@jensschuppe
[#4] Adjust API calls for changes in de.systopia.newsletter
e297c1e
@jensschuppe jensschuppe changed the title Per-profile permissions not available [D8/9] Per-profile permissions not available Nov 11, 2020
@jensschuppe jensschuppe changed the title [D8/9] Per-profile permissions not available Per-profile permissions not available Nov 11, 2020
jensschuppe added a commit that referenced this issue Nov 11, 2020
@jensschuppe
[#4] Adjust API calls for changes in de.systopia.newsletter
bb55d2d
jensschuppe added a commit that referenced this issue Nov 11, 2020
@jensschuppe
Merge branch 'issue/7.x/4'
c950506 
[#4] Per-profile permissions not available
jensschuppe added a commit that referenced this issue Nov 11, 2020
@jensschuppe
Merge branch 'issue/4' into 8.x
06ec2ee 
[#4] Per-profile permissions not available
@jensschuppe
Copy link
Collaborator Author

jensschuppe commented Nov 11, 2020 •
edited
Loading

Will be released with 1.0/7.x-1.0 (starting from 1.0-alpha5 for Drupal 8 and 7.x-1.0-alpha1 for Drupal 7)

Note that this requires systopia/de.systopia.newsletter version 1.0 (1.0-alpha1 at least)

@jensschuppe jensschuppe added the status:fixed The issue has been resolved (usually by committing/merging code) label Jul 7, 2021
@jensschuppe jensschuppe mentioned this issue Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensschuppe jensschuppe

Labels
enhancement New feature or request status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@jensschuppe