Do not replace error handler twice, avoiding infinite loops #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37.
The extension replaces the error handler to catch Smarty errors while validating the settings form (i.e. the actual greeting formulas). When the code replacing the error handler was called twice, the original error handler will be lost and the extension can not restore it. In the case of an error (which seems to be a deprecation warning being handled by the error handler), this leads to an infinite loop into our error handler.
This PR guards the error handler replacement by checking whether the replacement has already been done. Also, this clears the static class member which is being used for keeping track of the original error handler when the extension restores it.