Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving sessions fails when using special characters #3

Open
bjendres opened this issue Jan 27, 2021 · 1 comment
Open

Saving sessions fails when using special characters #3

bjendres opened this issue Jan 27, 2021 · 1 comment
Labels
bug Something isn't working
Milestone
1.3

Comments

@bjendres
Copy link
Member

Saving sessions can fail when using special characters (e.g. utf8mb4, BOM, etc).

Since this causes a hard DB error, the popup page doesn't receive a proper error and is left spinning.

The data be either:

  • filtered
  • marked as invalid input

The second option is to be preferred, to allow people to adjust their input accordingly.
@bjendres bjendres added the bug Something isn't working label Jan 27, 2021
@bjendres bjendres added this to the 1.0 milestone Jan 27, 2021
@jensschuppe jensschuppe modified the milestones: 1.0, 1.1 Oct 17, 2023
@jensschuppe jensschuppe changed the title Saving sessions fails Saving sessions fails when using special characters Oct 17, 2023
@jensschuppe
Copy link
Contributor

@bjendres should this be scheduled for version 1.1.0?

@bjendres bjendres modified the milestones: 1.1, 1.2 Feb 27, 2024
@jensschuppe jensschuppe modified the milestones: 1.2, 1.3 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@bjendres @jensschuppe