Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TABJS-13] Add txn hash in shell responses #92

Open
dtbuchholz opened this issue Nov 21, 2023 · 0 comments
Open

[TABJS-13] Add txn hash in shell responses #92

dtbuchholz opened this issue Nov 21, 2023 · 0 comments
Labels
cli Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync

Comments

@dtbuchholz
Copy link
Contributor

Summary

When working with the shell command, it'd be nice to get a transaction hash in the response after a mutating query is made. For example, the following query is invalid for a table t_31337_2 with schema i int, v text:

insert into t_31337_2 values (1, 0xf95980ee414ff1b68d66421500d4779b6d453c5e);

However, the information logged is simply:

{"updatedTable":"t_31337_2"}

When I go to query the table, there is no data (as expected), but I have no clue why since I do not have the txn hash.

Details

There are a couple of options. You could choose to add the txn hash to the mutation response where the information logged could be:

{"updatedTable":"t_31337_2", "txn_hash": "0x1234..."}

Alternatively, you could choose to not log a misleading updatedTable (since it wasn't updated), catch the error, and then log it on the spot (and include the txn hash, too).

See original issue here.

From SyncLinear.com | TABJS-13

@dtbuchholz dtbuchholz added cli Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant