Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads Rust version if specific point release already installed #134

Open
legoktm opened this issue Oct 31, 2021 · 1 comment
Open

Downloads Rust version if specific point release already installed #134

legoktm opened this issue Oct 31, 2021 · 1 comment
Labels
A-version Area: --rust-version, --version-range, --version-step C-enhancement Category: A new feature or an improvement for an existing one help wanted Call for participation: Help is requested to fix this issue

Comments

@legoktm
Copy link

legoktm commented Oct 31, 2021

Hi, cargo-hack is awesome, thank you for making it!

I'm running my CI pipeline using the rust:latest image, which always has the most recent point release installed:

root@a4a809c38181:/# rustup show
Default host: x86_64-unknown-linux-gnu
rustup home:  /usr/local/rustup

1.56.0-x86_64-unknown-linux-gnu (default)
rustc 1.56.0 (09c42c458 2021-10-18)

However, when I run something like cargo hack check 1.56.., it ends up redownloading the 1.56 toolchain, even though the image already has it installed. My guess is that this is because the image has 1.56.0 installed (with point release) while cargo-hack wants 1.56 (no point release).

Could cargo-hack somehow detect that the latest 1.56 release is 1.56.0 and re-use it if it's already installed?

@taiki-e taiki-e added A-version Area: --rust-version, --version-range, --version-step C-enhancement Category: A new feature or an improvement for an existing one labels Oct 31, 2021
@taiki-e
Copy link
Owner

taiki-e commented Nov 4, 2021

I would accept a PR to re-use 1.x.y toolchain as 1.x toolchain when it is the latest point release.

@taiki-e taiki-e added the help wanted Call for participation: Help is requested to fix this issue label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-version Area: --rust-version, --version-range, --version-step C-enhancement Category: A new feature or an improvement for an existing one help wanted Call for participation: Help is requested to fix this issue
Projects
None yet
Development

No branches or pull requests

2 participants