Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should --optional-deps enabled by default? #44

Open
taiki-e opened this issue May 26, 2020 · 2 comments
Open

Should --optional-deps enabled by default? #44

taiki-e opened this issue May 26, 2020 · 2 comments
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)

Comments

@taiki-e
Copy link
Owner

taiki-e commented May 26, 2020

No description provided.

@taiki-e taiki-e added this to the v0.4 milestone May 26, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented Jul 11, 2020 •
edited
Loading

It's too easy to forget this, and it's probably preferable to enable it by default.

@taiki-e taiki-e self-assigned this Jul 11, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented Sep 16, 2020

This can significantly increase test time in projects with many option dependencies, so we probably need to extend the --optional-deps flag so that only specified dependencies can be considered as feature flags. like --optional-deps=crate1,crate3

@taiki-e taiki-e mentioned this issue Sep 17, 2020
Merged
bors bot added a commit that referenced this issue Sep 18, 2020
@bors @taiki-e
Merge #51
1535b4d 
51: Allow only specified optional dependencies to be considered as features r=taiki-e a=taiki-e

Addresses #44 (comment)


Co-authored-by: Taiki Endo <[email protected]>
bors bot added a commit that referenced this issue Sep 18, 2020
@bors @taiki-e
Merge #51
10cfe7c 
51: Allow only specified optional dependencies to be considered as features r=taiki-e a=taiki-e

Addresses #44 (comment)


Co-authored-by: Taiki Endo <[email protected]>
@taiki-e taiki-e removed their assignment Oct 2, 2020
@taiki-e taiki-e added the A-features Area: features (--feature-powerset, --each-feature, etc.) label Oct 10, 2020
@taiki-e taiki-e modified the milestones: v0.4, v0.5 Oct 16, 2020
@taiki-e taiki-e added A-features Area: features (--feature-powerset, --each-feature, etc.) I-needs-decision and removed A-features Area: features (--feature-powerset, --each-feature, etc.) I-needs-decision labels Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taiki-e