-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing with FileNotFoundException
#377
Comments
@saurabharora90 |
Can you provide an email address to share the logs? Btw we updated to 1.17.0 and its the same issue |
@saurabharora90 |
Emailed the --info logs |
@saurabharora90 io.github.takahirom.roborazzi.RoborazziPlugin val results: List<CaptureResult> = resultDirFileTree.get().mapNotNull {
if (it.name.endsWith(".json")) {
CaptureResult.fromJsonFile(it.path) // **here**
} else {
null
}
} |
📝 val results: List<CaptureResult> = resultDirFileTree.get().mapNotNull {
if (it.name.endsWith(".json")) {
CaptureResult.fromJsonFile(it.path) // **here**
} else {
null
}
} fun fromJsonFile(filePath: String): CaptureResult {
val jsonElement = json.parseToJsonElement(FileReader(filePath).readText())
return json.decodeFromJsonElement<CaptureResult>(jsonElement)
} const val resultDirPathFromBuildDir = "test-results/roborazzi/results/"
val resultDirFileProperty =
project.layout.buildDirectory.dir(RoborazziReportConst.resultDirPathFromBuildDir)
val resultDirFileTree =
resultDirFileProperty.map { it.asFileTree } |
@saurabharora90 |
Yes we are running both variants. It is intentional for the time being. Though we plan to migrate away from that in the long run. For stack trace, I'll try to get it if you need them. Given the error doesn't happen all the time, it might take some time. |
We've disabled release for the past one week and have stopped seeing this issue |
Thanks. I tried to reproduce the problem in the integration tests but was unable to do so. Therefore, I'll wait for the person who has a project that can reproduce it. |
We've been using Roborazzi for a while. Recently we've started to see flakiness appear in our screenshot tests on Github CI.
We need to retry a bunch of times before it goes through. We've updated to the latest 1.16.1 version and continue to face this issue.
We have build cache setup on CI and even tried clearing the build cache but didn't have any luck with this.
The text was updated successfully, but these errors were encountered: