Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add centroid finder block #7

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Add centroid finder block #7

merged 4 commits into from
Jul 21, 2023

Conversation

davidasamy
Copy link
Contributor

Finds centroid of instance -> #3

index on david/instance-centroids: 8daa796 Add InstanceCentroid class and corresponding functions

remove debug code
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #7 (28b8f6d) into main (5903df4) will increase coverage by 6.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   90.00%   96.07%   +6.07%     
==========================================
  Files           3        4       +1     
  Lines          20       51      +31     
==========================================
+ Hits           18       49      +31     
  Misses          2        2              
Impacted Files Coverage Δ
sleap_nn/data/instance_centroids.py 100.00% <100.00%> (ø)
sleap_nn/data/providers.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidasamy
Copy link
Contributor Author

davidasamy commented Jul 20, 2023

Address:

  • Currently each sample read through LabelsReader is a singular instance and corresponding frame. Change this to a list of instances and a corresponding frame instead?
  • Currently centroids are always found through the bounding box midpoint find_points_bbox_midpoint, must also add option to specify anchor node.

@davidasamy davidasamy requested a review from talmo July 21, 2023 17:34
sleap_nn/data/instance_centroids.py Show resolved Hide resolved
sleap_nn/data/instance_centroids.py Outdated Show resolved Hide resolved
@talmo talmo changed the title Add Instance-Centroid-Finder block Add centroid finder block Jul 21, 2023
@davidasamy davidasamy marked this pull request as ready for review July 21, 2023 23:32
@talmo talmo merged commit e579925 into main Jul 21, 2023
5 checks passed
@talmo talmo deleted the david/instance-centroids branch July 21, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants