-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No PHP 8 Support #187
Comments
Yes, phpcd does not support php 8 yet. It is because the dependence BetterReflection does not support php 8 now. Please see Roave/BetterReflection#701 |
Hi! BetterReflection seems to be compatible with php 8 now. |
Hi @hirofumi-yaoita , I am following the recently changes of BetterReflection, and willing to make phpcd support php 8.x. However, I have switched to golang, and I do not have too much spare time to do such upgrade. When I developed phpcd in 2014, I rewrite the core logic of phpcomplete.vim into php code as much as I can. And I wish the PHP developer who are willing to use phpcd could have the ability to understand the php code of phpcd and they can change or improve phpcd by themself. So I wish you to make your own try to add php 8 supports for phpcd. And I will try my best to offer any help. Thanks. |
When phpcd.vim was developed, the language server protocol is not widely used as now days. And phpcd.vim lacks many critical features offered by language server protocol, for example, find symbol references. So what is the roadmap for phpcd? In my opinion, phpcd has no advantage than any php language server. phpcd is just a little better than the orignal phpcomplete.vim. In the early date of phpcd, there is no need to create any index data or file. All information needed for completions or jumps are fetched by the Reflection of PHP. As a result, phpcd is very simple. And elegant as well. However, during my daily usage, I found it is needed to jump to the implementations of certain interface. And this feature could not be implemented without index. So I added the phpid to index all php classes or interfaces. With this changes, phpcd lost its elegant. Maybe in the future, phpcd will become a lightweight language server, without any index data. And drop the phpid feature. |
@leandroramos @hirofumi-yaoita It seems easy to support php 8. Please test the php8 branch https://github.com/epii1/phpcd.vim/commits/php8 Thanks. |
Hi @epii1 Thank you for your reply.
Indeed, I also believe that this is the spirit of open source.
OMG! golang is so good language. Have a nice golang programing life. |
Hi. I'm tryin to use phpcd with PHP 8, but these errors occured:
I'm using PHP 7.4 until I can solve it. Thank you very much :)
The text was updated successfully, but these errors were encountered: