Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake target 'libmemcached' is not idempotent #88

Open
ligurio opened this issue Dec 2, 2021 · 0 comments
Open

CMake target 'libmemcached' is not idempotent #88

ligurio opened this issue Dec 2, 2021 · 0 comments
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@ligurio
Copy link
Member

ligurio commented Dec 2, 2021 •
edited
Loading

CMake target 'libmemcached' is not idempotent, I'll explain it in a snippet below.

$ cmake .
$ make libmemcached
<building libmemcached>

<no changes in third_party/libmemcached>

$ make libmemcached
<building libmemcached>

make libmemcached builds sources of libmemcached from scratch on each run.

Can be non-relevant if we will remove libmemcached, see #90.
@kyukhin kyukhin added this to the wishlist milestone Dec 10, 2021
@Totktonada Totktonada removed this from the wishlist milestone Feb 2, 2022
@Totktonada Totktonada added the code health Improve code readability, simplify maintenance and so on label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Totktonada @ligurio @kyukhin @TarantoolBot